feat: add wildcard domain support #871
Open
+61
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new optional field `wildcardDomain` in the admin schema and related forms. - Updated the database schema to include the `wildcardDomain` column. - Enhanced the domain generation logic to utilize the `wildcardDomain` when provided. - Added localization strings for the new `wildcardDomain` input in the settings. This change allows users to specify a wildcard domain for their server configurations.
Siumauricio
requested changes
Dec 13, 2024
Comment on lines
81
to
+84
| host: data.domain, | ||
| letsEncryptEmail: data.letsEncryptEmail, | ||
| certificateType: data.certificateType, | ||
| wildcardDomain: data.wildcardDomain, |
There was a problem hiding this comment.
This is not updating the value in the database, check in the backend mutation how the data is received.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an option for a custom wildcardDomain domain, just point *.example.com as an A record to your servers IP for your own wildcard domain.
When wildcard domain are entered we simplify the domain aswell.
Inspired from Vercel (example.vercel.app)
If I have forgot anything please let me know!