Security Enhancement #956
Closed
Security Enhancement #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance server security by defaulting to 127.0.0.1:3000 and adding rate-limiting. * Change the default host to `127.0.0.1` in `apps/api/src/index.ts` and `apps/dokploy/server/server.ts`. * Add a rate-limiting middleware to the `app` instance in `apps/api/src/index.ts`. * Introduce an environment variable `EXPOSE_ALL_INTERFACES` to toggle exposing `0.0.0.0` in `apps/dokploy/server/server.ts` and `apps/dokploy/.env.example`. * Add a toggle for `EXPOSE_ALL_INTERFACES` in the `WebServer` component in `apps/dokploy/components/dashboard/settings/web-server.tsx` with a warning about the associated risks.
Enhance security by changing default host and adding rate-limiting
|
I think i mess up something. Will re-open if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: #947
This pull request introduces several changes to enhance the functionality and security of the application, including rate limiting, environment configuration updates, and UI improvements for server settings.
Security and Performance Enhancements:
apps/api/src/index.ts: Added rate limiting middleware to limit each IP to 100 requests per 15 minutes, enhancing security against potential abuse.Environment Configuration:
apps/api/src/index.ts: Modified the server to bind to all network interfaces ifEXPOSE_ALL_INTERFACESis set totrue, otherwise binds to localhost.apps/dokploy/.env.example: AddedEXPOSE_ALL_INTERFACESenvironment variable to the example environment configuration file.UI and State Management:
apps/dokploy/components/dashboard/settings/web-server.tsx: Introduced a toggle switch to control theEXPOSE_ALL_INTERFACESsetting from the web UI, along with a warning alert when the setting is enabled. [1] [2] [3]Server Configuration:
apps/dokploy/server/server.ts: Updated the server to use theEXPOSE_ALL_INTERFACESenvironment variable to determine the host binding, ensuring consistency with the new configuration setting. [1] [2]