-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definition #31
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nadilas and I'll review next week.
@@ -1,5 +1,6 @@ | |||
const fs = require("fs"); | |||
const path = require("path"); | |||
const { jsonInputForTargetLanguage, InputData, quicktype } = require("quicktype-core"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, somehow I missed the imports when creating the patch
… type is not module (e.g. nextjs)
@ryan-blunden any way I can help? |
Sorry about the delay @nadilas. I’ll review this as soon as I can. |
Hey @ryan-blunden, just a reminder, this one probably got lost. |
Thanks for the PR @nadilas. Adding types to this project is definitely a worthwhile endeavor. This project has an explicit goal of having zero dependencies. That allows us to ensure that this project does not need to be patched as CVEs are found in external libraries. Unfortunately, this PR introduces a dependency on |
Hi @Piccirello, thanks for the update. There might be a misunderstanding this PR adds types to the generated output, so its usage is type-safe, hence the quicktype dependency. and not to this codebase. If there are no resources on your your end, I’m fine with publishing as a separate package if that’s ok with you. |
Was this ever published? This is a really important feature |
@ryanleecode it wasn’t. How urgently do you need it? |
Addresses #30