Skip to content

Commit

Permalink
asset, rdpq, toolchain: initial picolibc support
Browse files Browse the repository at this point in the history
  • Loading branch information
asiekierka committed Jul 6, 2024
1 parent e3c245b commit 32caa84
Show file tree
Hide file tree
Showing 5 changed files with 116 additions and 17 deletions.
12 changes: 12 additions & 0 deletions src/asset.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,13 @@ static fpos_t seekfn_none(void *c, fpos_t pos, int whence)
return -1;
}

#if defined(__PICOLIBC__) && defined(TINY_STDIO)
static int readfn_none(void *c, void *buf, size_t sz)
#elif defined(__PICOLIBC__)
static int readfn_none(void *c, char *buf, size_t sz)
#else
static int readfn_none(void *c, char *buf, int sz)
#endif
{
cookie_none_t *cookie = c;
assertf(!cookie->seeked, "Cannot seek in file opened via asset_fopen (it might be compressed)");
Expand All @@ -251,7 +257,13 @@ typedef struct {
uint8_t alignas(8) state[];
} cookie_cmp_t;

#if defined(__PICOLIBC__) && defined(TINY_STDIO)
static int readfn_cmp(void *c, void *buf, size_t sz)
#elif defined(__PICOLIBC__)
static int readfn_cmp(void *c, char *buf, size_t sz)
#else
static int readfn_cmp(void *c, char *buf, int sz)
#endif
{
cookie_cmp_t *cookie = (cookie_cmp_t*)c;
assertf(!cookie->seeked, "Cannot seek in file opened via asset_fopen (it might be compressed)");
Expand Down
9 changes: 9 additions & 0 deletions src/rdpq/rdpq_text.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ rdpq_textmetrics_t rdpq_text_printn(const rdpq_textparms_t *parms, uint8_t initi
rdpq_textmetrics_t rdpq_text_vprintf(const rdpq_textparms_t *parms, uint8_t font_id, float x0, float y0,
const char *utf8_fmt, va_list va)
{
#if defined(__PICOLIBC__) && defined(TINY_STDIO)
char *buf;
size_t n = vasprintf(&buf, utf8_fmt, va);

rdpq_textmetrics_t m = rdpq_text_printn(parms, font_id, x0, y0, buf, n);
free(buf);
return m;
#else
char buf[512];
size_t n = sizeof(buf);
char *buf2 = vasnprintf(buf, &n, utf8_fmt, va);
Expand All @@ -52,6 +60,7 @@ rdpq_textmetrics_t rdpq_text_vprintf(const rdpq_textparms_t *parms, uint8_t font
rdpq_textmetrics_t m = rdpq_text_printn(parms, font_id, x0, y0, buf2, n);
free(buf2);
return m;
#endif
}

rdpq_textmetrics_t rdpq_text_printf(const rdpq_textparms_t *parms, uint8_t font_id, float x0, float y0,
Expand Down
8 changes: 8 additions & 0 deletions src/system.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include <fcntl.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/time.h>
#include <sys/times.h>
#include <stdarg.h>
#include <stdint.h>
Expand All @@ -35,6 +36,13 @@
#define STDERR_FILENO 2
/** @} */

#if defined(__PICOLIBC__) && defined(TINY_STDIO)
/* Force weakly referenced default stdin/stdout/stderr implementations to be linked. */
__asm__(".equ stdin_reference, stdin");
__asm__(".equ stdout_reference, stdout");
__asm__(".equ stderr_reference, stderr");
#endif

/**
* @brief Stack size
*
Expand Down
85 changes: 68 additions & 17 deletions tools/build-toolchain.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ N64_BUILD=${N64_BUILD:-""}
N64_HOST=${N64_HOST:-""}
N64_TARGET=${N64_TARGET:-mips64-elf}

# Toolchain configuration options.
N64_USE_PICOLIBC=${N64_USE_PICOLIBC:-"false"}
N64_USE_PICOLIBC_TINYSTDIO=${N64_USE_PICOLIBC_TINYSTDIO:-"false"}
N64_USE_PICOLIBC_LEGACY_STDIO=true
if [ "$N64_USE_PICOLIBC_TINYSTDIO" == "true" ]; then
N64_USE_PICOLIBC_LEGACY_STDIO=false
fi

# Set N64_INST before calling the script to change the default installation directory path
INSTALL_PATH="${N64_INST}"
# Set PATH for newlib to compile using GCC for MIPS N64 (pass 1)
Expand All @@ -38,8 +46,9 @@ GCC_CONFIGURE_ARGS=()
BINUTILS_V=2.42
GCC_V=14.1.0
NEWLIB_V=4.4.0.20231231
GMP_V=6.3.0
MPC_V=1.3.1
PICOLIBC_V=348601d31ac56e9628ccf9fce5c53b792b79f97f
GMP_V=6.3.0
MPC_V=1.3.1
MPFR_V=4.2.1
MAKE_V=${MAKE_V:-""}

Expand Down Expand Up @@ -104,8 +113,13 @@ test -d "binutils-$BINUTILS_V" || tar -xzf "binutils-$BINUTILS_V.tar.gz"
test -f "gcc-$GCC_V.tar.gz" || download "https://ftp.gnu.org/gnu/gcc/gcc-$GCC_V/gcc-$GCC_V.tar.gz"
test -d "gcc-$GCC_V" || tar -xzf "gcc-$GCC_V.tar.gz"

test -f "newlib-$NEWLIB_V.tar.gz" || download "https://sourceware.org/pub/newlib/newlib-$NEWLIB_V.tar.gz"
test -d "newlib-$NEWLIB_V" || tar -xzf "newlib-$NEWLIB_V.tar.gz"
if [ "$N64_USE_PICOLIBC" == "true" ]; then
test -f "picolibc-$PICOLIBC_V.zip" || ( download "https://github.com/picolibc/picolibc/archive/$PICOLIBC_V.zip" && mv "$PICOLIBC_V.zip" "picolibc-$PICOLIBC_V.zip" )
test -d "picolibc-$PICOLIBC_V" || unzip "picolibc-$PICOLIBC_V.zip"
else
test -f "newlib-$NEWLIB_V.tar.gz" || download "https://sourceware.org/pub/newlib/newlib-$NEWLIB_V.tar.gz"
test -d "newlib-$NEWLIB_V" || tar -xzf "newlib-$NEWLIB_V.tar.gz"
fi

if [ "$GMP_V" != "" ]; then
test -f "gmp-$GMP_V.tar.bz2" || download "https://ftp.gnu.org/gnu/gmp/gmp-$GMP_V.tar.bz2"
Expand Down Expand Up @@ -221,19 +235,56 @@ make all-target-libgcc -j "$JOBS"
make install-target-libgcc || sudo make install-target-libgcc || su -c "make install-target-libgcc"
popd

# Compile newlib for target.
mkdir -p newlib_compile_target
pushd newlib_compile_target
CFLAGS_FOR_TARGET="-DHAVE_ASSERT_FUNC -O2 -fpermissive" ../"newlib-$NEWLIB_V"/configure \
--prefix="$CROSS_PREFIX" \
--target="$N64_TARGET" \
--with-cpu=mips64vr4300 \
--disable-threads \
--disable-libssp \
--disable-werror
make -j "$JOBS"
make install || sudo env PATH="$PATH" make install || su -c "env PATH=\"$PATH\" make install"
popd
if [ "$N64_USE_PICOLIBC" == "true" ]; then
# Compile picolibc for target.
mkdir -p picolibc_compile_target
pushd picolibc_compile_target
meson setup \
--cross-file=../../meson-cross.txt \
-Dmultilib=false \
-Dpicocrt=false \
-Dpicolib=false \
-Dsemihost=false \
-Dspecsdir=none \
-Dtests=false \
-Dtinystdio="$N64_USE_PICOLIBC_TINYSTDIO" \
-Dfast-bufio=true \
-Dio-long-long=true \
-Dio-pos-args="$N64_USE_PICOLIBC_TINYSTDIO" \
-Dio-percent-b=true \
-Dposix-console=true \
-Dformat-default=double \
-Dnewlib-fseek-optimization="$N64_USE_PICOLIBC_LEGACY_STDIO" \
-Dnewlib-fvwrite-in-streamio="$N64_USE_PICOLIBC_LEGACY_STDIO" \
-Dnewlib-io-float="$N64_USE_PICOLIBC_LEGACY_STDIO" \
-Dnewlib-stdio64=false \
-Dnewlib-unbuf-stream-opt="$N64_USE_PICOLIBC_LEGACY_STDIO" \
-Dnewlib-nano-malloc=false \
-Dnewlib-multithread=false \
-Dnewlib-retargetable-locking=false \
-Dthread-local-storage=false \
-Dprefix="$CROSS_PREFIX" \
-Dlibdir=mips64-elf/lib \
-Dincludedir=mips64-elf/include \
../"picolibc-$PICOLIBC_V"
ninja -j "$JOBS"
ninja install || sudo env PATH="$PATH" ninja install || su -c "env PATH=\"$PATH\" ninja install"
popd
else
# Compile newlib for target.
mkdir -p newlib_compile_target
pushd newlib_compile_target
CFLAGS_FOR_TARGET="-DHAVE_ASSERT_FUNC -O2 -fpermissive" ../"newlib-$NEWLIB_V"/configure \
--prefix="$CROSS_PREFIX" \
--target="$N64_TARGET" \
--with-cpu=mips64vr4300 \
--disable-threads \
--disable-libssp \
--disable-werror
make -j "$JOBS"
make install || sudo env PATH="$PATH" make install || su -c "env PATH=\"$PATH\" make install"
popd
fi

# For a standard cross-compiler, the only thing left is to finish compiling the target libraries
# like libstd++. We can continue on the previous GCC build target.
Expand Down
19 changes: 19 additions & 0 deletions tools/meson-cross.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[binaries]
# Meson 0.53.2 doesn't use any cflags when doing basic compiler tests,
# so we have to add -nostdlib to the compiler configuration itself or
# early compiler tests will fail. This can be removed when picolibc
# requires at least version 0.54.2 of meson.
c = ['mips64-elf-gcc', '-nostdlib']
ar = 'mips64-elf-ar'
as = 'mips64-elf-as'
nm = 'mips64-elf-nm'
strip = 'mips64-elf-strip'

[host_machine]
system = 'none'
cpu_family = 'mips64'
cpu = 'mips64vr4300'
endian = 'big'

[properties]
skip_sanity_check = true

0 comments on commit 32caa84

Please sign in to comment.