Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped display antialiasing options into filters #408

Merged
merged 18 commits into from
Aug 25, 2023

Conversation

SpookyIluha
Copy link
Contributor

  • The current display options include "anti-aliasing" settings that are cryptic and don't match expectations, this PR fixes any confusion about what is actually happening to the output with selected display filtering options.
  • This PR changes and deprecates antialias_t (used only in display_init) into filter_options_t with similar options (deprecated AA options are mapped to them directly) and verbose comments, explaining each filter.
  • filter_options_t is an enum with only valid and useful filtering options, such as resampling, AA and de-dithering.
  • Also updated gamma comments to better illustrate their use-cases.

Copy link
Collaborator

@rasky rasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Spooky, this looks like a fantastic improvement and the new vi.h is a very good step in the direction of having a real VI library at some point.

Note that doxygen is failing, please have a look at the CI failures. We need to fix those before merging.

Also please rebase the branch on latest trunk, as I want to use the rebase-merge strategy.

include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/vi.h Outdated Show resolved Hide resolved
include/display.h Outdated Show resolved Hide resolved
@SpookyIluha SpookyIluha requested a review from rasky August 25, 2023 12:37
@rasky rasky merged commit 8ded366 into DragonMinded:trunk Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants