display: Restore VI active check based on set color depth mode #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasky
approved these changes
Aug 19, 2023
Earlier H_VIDEO-based check introduced a regression that sometimes caused real hardware to hang when changing video resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier H_VIDEO-based check introduced a regression that sometimes caused real hardware to hang when changing video resolution. While the VI will not send a video signal at all when color depth mode field is 0, it will still send a signal when H_VIDEO is 0, albeit with an entirely black picture. This could still cause the VI to be confused and crash if register changes were done outside VBLANK.