Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor examples Makefiles #427

Merged
merged 5 commits into from
Sep 3, 2023
Merged

Refactor examples Makefiles #427

merged 5 commits into from
Sep 3, 2023

Conversation

meeq
Copy link
Contributor

@meeq meeq commented Sep 1, 2023 •
edited
Loading

More groundwork for my upcoming Joypad subystem PR:

  • The examples Makefile now uses an evaluated template for each example directory. This eliminates the tedious and error-prone process of making sure the all, clean, and .PHONY targets are kept in sync.
  • I had to clean up the old examples that were still using bespoke Makefiles because deprecation warnings were being treated as errors. All examples now use n64.mk
  • Removed obsolete dfsdemo example and references to libmikmod in build.sh

@meeq
Copy link
Contributor Author

meeq commented Sep 1, 2023 •
edited
Loading

GitHub Actions are failing because of Mikmod 😞
Should I just delete the dfsdemo test in this PR?

Fixed in 9d316b0

This was referenced Sep 2, 2023
Merged
Merged
@rasky rasky merged commit 502b388 into DragonMinded:trunk Sep 3, 2023
4 checks passed
@meeq meeq deleted the refactor-examples branch September 3, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meeq @rasky