Move threads.h to new newlib override folder searched before other includes #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anacierdem
reviewed
Oct 24, 2024
| @@ -212,6 +211,8 @@ install: install-mk libdragon | |||
| install -Cv -m 0644 src/fatfs/ff.h $(INSTALLDIR)/mips64-elf/include/fatfs/ff.h | |||
| install -Cv -m 0644 src/fatfs/ffconf.h $(INSTALLDIR)/mips64-elf/include/fatfs/ffconf.h | |||
| install -Cv -m 0644 include/ioctl.h $(INSTALLDIR)/mips64-elf/include/ioctl.h | |||
| mkdir -p $(INSTALLDIR)/mips64-elf/include/newlib_overrides | |||
There was a problem hiding this comment.
Should we name it to something like early_includes or is this only meant for newlib only?
There was a problem hiding this comment.
The current file in the folder overrides newlib, so I thought the chosen name here was the most clearly documenting one (it describes its purpose rather than just what it does), and I also suspect it will be common use-case for future includes. If we think there is a need to override files from some other source (libstdc++? some GCC-provided includes?) in the future, I can rename the folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily makes it easier to create software packages for libdragon that doesn't conflict with newlib packages, though it is also useful for documentation reasons (easy to see which files are meant to override newlib includes) and possibly useful for testing or reverting during libdragon development as well.