Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to bearer token type #185

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Fall back to bearer token type #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Duende.Bff/Extensions/HttpContextExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,11 @@ public static async Task<AccessTokenResult> GetManagedAccessToken(this HttpConte
new AccessTokenRetrievalError("Missing DPoP Json Web Key for DPoP token"),
{ AccessTokenType: string accessTokenType } =>
new AccessTokenRetrievalError($"Unexpected access token type: {accessTokenType} - should be one of 'DPoP' or 'Bearer'"),
{ AccessTokenType: null } =>
new AccessTokenRetrievalError("Missing access token type - should be one of 'DPoP' or 'Bearer'")
{ AccessTokenType: null } =>
// Fall back to bearer tokens when the access token type is absent.
// In some edge cases, we've seen bearer tokens not have their type specified.
// But that wouldn't be the case if you had a DPoP token.
new BearerTokenResult(token.AccessToken)
};

static async Task<ClientCredentialsToken> GetUserOrClientAccessTokenAsync(HttpContext context, UserTokenRequestParameters? userAccessTokenParameters)
Expand Down
Loading