-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Playwright test to VIN Scanner #24
Open
eugene-dynamsoft
wants to merge
4
commits into
main
Choose a base branch
from
playwright-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+469
−96
Commits on Oct 16, 2024
-
Initialized the repo, added a ReadMe and added the first sample direc…
…tory VINScanner feat: VIN Scanner sample (#1) * feat: VIN Scanner sample * fix: remove css that's not used. * fix: license key * fix: removed console log * fix: Remove Test --------- Co-authored-by: felixindrawan <[email protected]> fix: VINScanner - code/ui improvements fix: remove css that's not used. fix: license key fix: removed console log fix: Remove Test fix: shortened code for imagedata, removed scanlaser on load, simplified code Create main.yml to setup CI feat: Add Code 128 and PDF417 to the template feat: VINScanner - update DLR DIP and template * feat: VINScanner - update DLR DIP and template * fix: removed dip script * add DIP as engineResourcePath and reverted DLR import * add DIP as engineResourcePath and reverted DLR import * fix: updated library * fix: rgb colors --------- Co-authored-by: felixindrawan <[email protected]> feat: ui enhancement, update library fix: working feat: add boxshadow fix: notification to have none display fix: used different color for background Bug: fix utm_source from github to samples Bug: fix utm_source to only say samples feat: remove camera list on click and optimized ui feat(VINScanner): update model year parse fix: Copy result and save image button moved to the top fix: css fix: moved VIN code to the top fix(VINScanner): homepage mobile ui spacing feat(VINScanner): allow vertical scan on barcode mode (#11) feat(VINScanner): add resolution options (#10) * feat(VINScanner): add resolution select * fix: camera list width * feat: notification on camera switch * fix: judge resolution * fix: button switches --------- Co-authored-by: felixindrawan <[email protected]> First check-in on playwright script. The 'helloworld.spec.ts' script will run test on on the vanilla js helloworld demo to check the title and get the cameraEnhancer class object to test out the getResolution() methods. The 'ui-test.spec.ts' script will run a test on felix's DBR/DLR integration to verify the title and make sure use can select all 3 different scan mode (text+barcode, text only, barcode only). Clean up the helloworld ui test and strucutred using POM pattern. Added install and test script to package.json file. Fixed Typo refactor playwright test to use fixtures and clean up the POM pattern. Refactored the project again to separate the test for minimum-elements and index page. Chrome should have all tests working properly now. Firefox having an issue of getting all available camera resolutions. Could be related to using fake camera permission, will need to look further into this. Added Test to locate the ddl selector for resolution First check-in on playwright script. The 'helloworld.spec.ts' script will run test on on the vanilla js helloworld demo to check the title and get the cameraEnhancer class object to test out the getResolution() methods. The 'ui-test.spec.ts' script will run a test on felix's DBR/DLR integration to verify the title and make sure use can select all 3 different scan mode (text+barcode, text only, barcode only). Clean up the helloworld ui test and strucutred using POM pattern. Added install and test script to package.json file. Fixed Typo refactor playwright test to use fixtures and clean up the POM pattern. Refactored the project again to separate the test for minimum-elements and index page. Chrome should have all tests working properly now. Firefox having an issue of getting all available camera resolutions. Could be related to using fake camera permission, will need to look further into this. Added Unittest for index.html page. Adding Code Coverage dependencies and initial commit to the unittest for index page (VIN Scanner) Refactored VIN Scanner e2e test to update the locator paths and optimize the flow Added GitHub action to run test on container. Add GitHub workflow to run test on container Clean up unnecessary .gitignore and move the playwright yml workflow file to the root Fix the install dependency step for playwright test action Navigate into VINScanner page to execute playwright tests. try to execute all action scripts within the VINScanner folder Set default working directory to VINScanner. Clean up playwright.config.ts Added minimum-elements unittest Experimenting with GitHub container test execution Try setting up docker image container to run in GitHub Action fix: json Starting local server and run against it on github action added wait-on package dependency. Updated the wait-on path. Updated the wait-on command to add a timeout and avoid using localhost Experiment using start-server-and-test npm package to kick off build dev & run playwright test. Try running with a test file that will for sure pass. draft: playwright test fix: playwright.yml to add https fix: install deps remove openssl download fix: start with vite fix: test url fix: playwright config fix: get title fix: added camera options feat: add documentation on readme fix: removed gitignore for lock fix: rmeoved unused config file fix: setup config.ts fix and add more test for minimum-elements fix: added testDir Try to fix the playwright yml to execute 'npm run test' which should run npx playwright test fix: added back yml command Updated the testDir to point to VINSCanner/tests folder. Change all page.goto path to local file since baseURL is defined in the playwright config setting already. enabled headless mode to allow execution with github action adding longer delay to ensure video stream starts before validating the isPlaying bool. feat(VINScanner): allow vertical scan on barcode only fix: ui on mobile and bug on camera rotate fix: scan mode showing up on result feat: removed restart video on header fix: sizing Minor fixes on VINScanner test. comment out the webkit test for now as desktop safari does not run properly in windows. Minor fix on cameraEnhancer copmarison in minimumElement test. Clean up test and ensure chrome/firefox are running with headless mode. Setting up non parallel test for test-VinScanner to avoid validation errro for selecting different scan mode buttons. Adding some try-catch block and update the execution of min-element test to be serial instead of parallel to prevent test failed turned on ignoreHTTPSErrors for all projects Due to the playwright bug for waitFor not really work, changing the wait to validate whether the button container exists prior to clicking on the scan mode buttons. revert the change to wait for scanModeContainer in the test and try to add a hard timeout instead. First check-in on playwright script. The 'helloworld.spec.ts' script will run test on on the vanilla js helloworld demo to check the title and get the cameraEnhancer class object to test out the getResolution() methods. The 'ui-test.spec.ts' script will run a test on felix's DBR/DLR integration to verify the title and make sure use can select all 3 different scan mode (text+barcode, text only, barcode only). Clean up the helloworld ui test and strucutred using POM pattern. Added install and test script to package.json file. Fixed Typo Fixed Typo fix: json Try running with a test file that will for sure pass. fix: install deps fix: added back yml command enabled headless mode to allow execution with github action fix: remove fields from result that's not detected fix: sizing fix: position of scan region on min feat: moved cameraEnhancer cvRouter cameraView for debugging Clean up test and ensure chrome/firefox are running with headless mode. Setting up non parallel test for test-VinScanner to avoid validation errro for selecting different scan mode buttons. Adding some try-catch block and update the execution of min-element test to be serial instead of parallel to prevent test failed turned on ignoreHTTPSErrors for all projects revert the change to wait for scanModeContainer in the test and try to add a hard timeout instead. Adding userAgent header to try avoiding firefox to think the playwright script is a bot. Also fixed the scan mode text to "Text", "Barcode", and "Both" Adding differenet waitForLoadState to prevent firefox headless mode to pass. use fake camera/ui for chrome Setting firefox to run in debug mode when executing in headless Clean up the script and removed unused function. This should fixed both #15 and #16. fix: updated error msg on errors caught feat: add previews for PRs
Configuration menu - View commit details
-
Copy full SHA for 321718d - Browse repository at this point
Copy the full SHA 321718dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef11f1f - Browse repository at this point
Copy the full SHA ef11f1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb770e - Browse repository at this point
Copy the full SHA fbb770eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81054c7 - Browse repository at this point
Copy the full SHA 81054c7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.