Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cosine bell viz step #100

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 27, 2023

The lon and lat fields are not available in the MPAS mesh file, but rather come from remapping to a regular lat-lon grid.

We also need to skip matplotlib version 3.7.2 because of a known bug: matplotlib/matplotlib#26291

Checklist

  • Testing comment in the PR documents testing used to verify the changes

The `lon` and `lat` fields are not available in the MPAS mesh file,
but rather come from remapping to a regular lat-lon grid.
We don't want to use version 3.7.2 because of a known bug
with tight layouts and insets: matplotlib/matplotlib#26291
@xylar xylar self-assigned this Jul 27, 2023
@xylar xylar added bug Something isn't working ocean Related to ocean tests or analysis labels Jul 27, 2023
@xylar
Copy link
Collaborator Author

xylar commented Jul 27, 2023

Testing

The ocean/global_convergence/qu/cosine_bell_with_viz and ocean/global_convergence/icos/cosine_bell_with_viz tests pass with this branch (and fresh call to ./configure_polaris_envs.py to update the conda environment) on Chrysalis, whereas they were failing with main.

@xylar xylar merged commit 1fb9b62 into E3SM-Project:main Jul 27, 2023
5 checks passed
@xylar xylar deleted the fix-cosine-bell-viz branch July 27, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant