-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get maxLevelCell from ds, not ds_mesh in viz #101
Get maxLevelCell from ds, not ds_mesh in viz #101
Conversation
@cbegeman, the
While one fix would be to add In particular, I don't think |
This is because `ds_mesh` should only contain horizontal mesh variables.
f131549
to
44c34c4
Compare
TestingI ran this with the following tests and they all passed:
I had to manually check the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar I agree with your changes. I think this is a better approach.
Great, thanks @cbegeman! |
This is because
ds_mesh
should only contain horizontal mesh variables.Checklist
Testing
comment in the PR documents testing used to verify the changes