Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shared steps capability design doc #109

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented Aug 18, 2023

Currently, this PR just contains the design doc for the shared steps capability

Checklist

  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected

@cbegeman
Copy link
Collaborator Author

@xylar I haven't had much time to work on this, but I figured it was better to get a few thoughts out there while our memories were still fresh from our conversation. Feel free to directly push to this branch with your thoughts. We didn't have a chance to chat about which of us would be writing this design doc, so I just assumed it would be a joint effort. Feel free to take over if you like!

docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
@xylar xylar mentioned this pull request Aug 20, 2023
7 tasks
Co-authored-by: Carolyn Begeman <[email protected]>
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments and updates to the design doc, as I work my way toward filling in the implementation and testing parts.

docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
docs/design_docs/shared_steps.md Outdated Show resolved Hide resolved
@xylar
Copy link
Collaborator

xylar commented Sep 14, 2023

@cbegeman, I added quite a bit more here. Please have a look when you get back to NM.

@xylar xylar added the documentation Improvements or additions to documentation label Sep 14, 2023
@xylar xylar mentioned this pull request Sep 15, 2023
7 tasks
@cbegeman
Copy link
Collaborator Author

@xylar I think this looks great! I'm removing the other documentation checkboxes since they are addressed in other PRs. I'll leave this PR unmerged until the other PRs are approved.

@cbegeman cbegeman changed the title New shared steps capability New shared steps capability design doc Sep 19, 2023
@cbegeman cbegeman marked this pull request as ready for review September 19, 2023 21:00
@cbegeman
Copy link
Collaborator Author

@xylar Feel free to merge this PR at the same time as you merge the implementation PRs.

@xylar xylar merged commit 683cfac into E3SM-Project:main Sep 22, 2023
5 checks passed
@xylar xylar deleted the reorg-for-shared-steps branch September 22, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants