-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update exact synonym display on frontend #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome that this is being attacked! Good to see.
Is there a plan to add support for broad, narrow and related synonyms? Especially the latter has a lot of examples across ontologies!
@matentzn this change atm differentiate between exactMatch synonym and considers broad/narrow/related synonym as close match synonyms ... have a look at the below screenshot But if you want we can separate the related synonyms bit as well.. so on UI we can have something like: exactSynonym -> ...... |
Why not go all on and separate them all as they are curated? Ontologies that make the effort to separate would certainly want to see exactly what they have curated? I am not concerned at all about a longer display, I think this information is very useful, and in fact, we have the opportunity here to have ontology developers separate more cleanly between these synonym types! |
(And as per naming, I would just use "Close synonyms", "Related synonym", "Broad synonyms" and "Narrow synonyms", I don't know where the "match" comes from in your display).. Looks good though! |
I agree with @matentzn on both counts, and thanks @haideriqbal this is awesome! |
will make the necessary changes then. Thanks both |
Amazing @haideriqbal!!! Love it! |
This is fantastic!!! Thank you @haideriqbal !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
solves this: #368