Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exact synonym display on frontend #796

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

haideriqbal
Copy link
Collaborator

@haideriqbal haideriqbal commented Nov 11, 2024

solves this: #368

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome that this is being attacked! Good to see.

Is there a plan to add support for broad, narrow and related synonyms? Especially the latter has a lot of examples across ontologies!

@haideriqbal
Copy link
Collaborator Author

Awesome that this is being attacked! Good to see.

Is there a plan to add support for broad, narrow and related synonyms? Especially the latter has a lot of examples across ontologies!

@matentzn this change atm differentiate between exactMatch synonym and considers broad/narrow/related synonym as close match synonyms ... have a look at the below screenshot

Screenshot 2024-11-11 at 12 05 19

But if you want we can separate the related synonyms bit as well.. so on UI we can have something like:

exactSynonym -> ......
relatedSynonym -> .............
closestSynonym -> ................

@matentzn
Copy link
Contributor

Why not go all on and separate them all as they are curated? Ontologies that make the effort to separate would certainly want to see exactly what they have curated? I am not concerned at all about a longer display, I think this information is very useful, and in fact, we have the opportunity here to have ontology developers separate more cleanly between these synonym types!

@matentzn
Copy link
Contributor

(And as per naming, I would just use "Close synonyms", "Related synonym", "Broad synonyms" and "Narrow synonyms", I don't know where the "match" comes from in your display)..

Looks good though!

@jamesamcl
Copy link
Member

I agree with @matentzn on both counts, and thanks @haideriqbal this is awesome!

@haideriqbal
Copy link
Collaborator Author

will make the necessary changes then. Thanks both

@haideriqbal
Copy link
Collaborator Author

Now synonyms will appear as they are curated in the ontology file.

Screenshot 2024-11-11 at 13 22 02

@matentzn
Copy link
Contributor

Amazing @haideriqbal!!! Love it!

@sabrinatoro
Copy link

This is fantastic!!! Thank you @haideriqbal !!

Copy link
Collaborator

@henrietteharmse henrietteharmse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@haideriqbal haideriqbal merged commit b85e4c1 into dev Nov 12, 2024
1 check passed
@haideriqbal haideriqbal deleted the fix-exact-synonym-issue branch November 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants