Some code clean up and enhancements

[waterflow80]

Did some code clean up, loggers, exceptions, info messages, etc

[apriltuesday]

Still need to check that level is non-null here...

[apriltuesday]

Or actually, can you make this the default case in your switch statement? Then it happens after the null check anyway.

[waterflow80]

True,
Actually the order of the conditions was not correct.
Just fixed it.

[waterflow80]

Or actually, can you make this the default case in your switch statement? Then it happens after the null check anyway.

case "1" and case null have actually the same code, but we can't put case null in Java (at least for our version), so I think adding the default case will lead to code duplicate..

[apriltuesday]

I actually meant something like:

if (level == null) level = "none";
switch (level) {
    case "1":
    case "none":
        ...
    case "2":
        ...
    default:
        return <BAD_REQUEST>
}

But the current ordering is good too (and probably makes more sense) 👍

[waterflow80]

Ah okay got you,
I think your approach looks more beautiful , so I'll go for it