Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the digits verification for seqCol arrays to be digested - ingestion endpoint #46

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

waterflow80
Copy link
Collaborator

@waterflow80 waterflow80 commented Aug 26, 2023

closes #45
I was able to insert seqCol objects related to asm_accession: GCA_002263795.4 locally.

@waterflow80
Copy link
Collaborator Author

I think this PR might solve the issue for most of the assembly's (including GCA_002263795.4),
however it will fail when having an assembly with an array of names composed only with digits, eg: [100, 101, 102, 103] (Not sure if it does exist)
Because in that case it will be treated like a lengths array in the toString() method of the JSONExtData class.

I will make another PR that solves this issue with all possible test cases where I'll be refactoring the toString() method.

If there are currently some assemblies that has only digits in their names array then I believe we should discard this PR, otherwise we can keep it to make the service work with most of the assemblies and do the refactoring later.

@waterflow80 waterflow80 merged commit c7b9ebc into EBIvariation:main Aug 31, 2023
1 check passed
@waterflow80 waterflow80 deleted the fix-issue-45 branch October 20, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeqCol ingestion error - Unrecognized or malformed JSON token: X
3 participants