Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rename current_fp/current_cp to j_fp/j_cp #5314

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Sep 24, 2024

This makes the name shorter and more consistent with the rest of the code.

Note that this will break the Python access API.

@EZoni
Copy link
Member

EZoni commented Sep 24, 2024

Just a thought, as we use upper-case E and B for the fields, should we use upper-case J for the current as well? I think it's typically written as J, not j, in textbook formulas. Also, in code, j is easy to confuse with a count index.

@RemiLehe RemiLehe changed the title Rename current_fp/current_cp to j_fp/j_cp [WIP] Rename current_fp/current_cp to j_fp/j_cp Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants