Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AMReX/pyAMReX/PICSAR: weekly update #5391

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Oct 14, 2024

  • Weekly update to latest AMReX:
./Tools/Release/updateAMReX.py

Weekly update to latest pyAMReX:

./Tools/Release/updatepyAMReX.py

Weekly update to latest PICSAR (no changes):

./Tools/Release/updatePICSAR.py

@EZoni EZoni added the component: third party Changes in WarpX that reflect a change in a third-party library label Oct 14, 2024
@WeiqunZhang
Copy link
Member

Looks like WarpX's NamedComponentParticleContainer needs an update. AddRealComp(const std::string& name, ...) exists now in AMReX.

@EZoni
Copy link
Member Author

EZoni commented Oct 14, 2024

@atmyers

I renamed the WarpX functions AddIntComp and AddRealComp, defined in Source/Particles/NamedComponentParticleContainer.H, as NewIntComp and NewRealComp, respectively, in order to avoid confusion with the AMReX functions of the same name, defined in Src/Particle/AMReX_ParticleContainer.H.

Does this look good to you? There are only two instances left where we are directly calling the AMReX functions from WarpX, without wrapping them in WarpX functions.

It's not clear to me whether the goal of recent PRs such as AMReX-Codes/amrex#4163 was to remove the WarpX functions and use directly the AMReX ones.

@EZoni
Copy link
Member Author

EZoni commented Oct 14, 2024

@atmyers

Also, in WarpX's newly renamed functions NewIntComp and NewRealComp we call the AMReX functions AddIntComp and AddRealComp by passing only the boolean comm flag. I have not changed this in this PR. However, I'm wondering if we are supposed to be passing also the name strings when we call those AMReX functions.

@EZoni EZoni changed the title AMReX/pyAMReX/PICSAR: weekly update [WIP] AMReX/pyAMReX/PICSAR: weekly update Oct 15, 2024
@EZoni
Copy link
Member Author

EZoni commented Oct 15, 2024

Discussed on Slack:
@atmyers will open a PR to call the new AMReX functions and remove NamedComponentParticleContainer from WarpX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants