Reference Particle: Store Charge & Mass #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
enhancement
ax3l
force-pushed
the
topic-store-ref-charge-mass
branch
3 times, most recently
from
f27b206
to
587b8c2
Compare
ax3l
commented
Aug 31, 2022
ax3l
commented
Aug 31, 2022
ax3l
commented
Aug 31, 2022
Store the mass and charge of the reference particle. This simpliifes init logic and is useful for later I/O tasks of meta data.
ax3l
force-pushed
the
topic-store-ref-charge-mass
branch
from
e67d523
to
0dd09fd
Compare
This was referenced Aug 31, 2022
ax3l
commented
Aug 31, 2022
ax3l
commented
Aug 31, 2022
ax3l
force-pushed
the
topic-store-ref-charge-mass
branch
2 times, most recently
from
dec4453
to
9ab0898
Compare
ax3l
force-pushed
the
topic-store-ref-charge-mass
branch
from
9ab0898
to
cb56292
Compare
n01r
approved these changes
Aug 31, 2022
| } | ||
| else { | ||
| qm = 0.0; | ||
| else { // default to electron |
There was a problem hiding this comment.
Wouldn't I be able to set up muons, for instance, if I provided a name and qe and massE for them?
There was a problem hiding this comment.
yes, we did not add that case yet but could issue a warning, for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the mass and charge of the reference particle.
This simplifies init logic and is useful for later I/O tasks of meta data.
Needed for #162 and #214.