Merge branch 'release/2.3.6'

EDCD · Jun 24, 2017 · 318e807 · 318e807
2 parents ab87ddc + c8355a5
commit 318e807
Show file tree

Hide file tree

Showing 11 changed files with 439 additions and 81 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,3 +1,12 @@
+#2.3.6
+  * Update miner role to provide better defaults
+  * Fix issue where torpedo special effects were not showing
+  * Fix typo causing long range blueprint to not modify shot speed in some circumstances
+  * Fix for Spanish translation of Chaff Launcher (thanks to DamonFstr)
+  * Update for Russian translation (thanks to LeeNTien)
+  * Use coriolis-data 2.3.6:
+    * Add shotspeed modifier to cannon/multi-cannon/fragment cannon
+
 #2.3.5
   * Ensure that hidden blueprint effects are applied when a blueprint is selected
   * Handle display when summary values show thrusters disabled but current mass keeps them enabled

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "coriolis_shipyard",
-  "version": "2.3.5",
+  "version": "2.3.6",
   "repository": {
     "type": "git",
     "url": "https://github.com/EDCD/coriolis"

diff --git a/src/app/components/ModificationsMenu.jsx b/src/app/components/ModificationsMenu.jsx
@@ -88,7 +88,7 @@ export default class ModificationsMenu extends TranslatedComponent {
     const translate = language.translate;
 
     const specials = [];
-    const specialsId = m.missile ? 'specials_' + m.missile : 'specials';
+    const specialsId = m.missile && Modifications.modules[m.grp]['specials_' + m.missile] ? 'specials_' + m.missile : 'specials';
     if (Modifications.modules[m.grp][specialsId] && Modifications.modules[m.grp][specialsId].length > 0) {
       const close = this._specialSelected.bind(this, null);
       specials.push(<div style={{ cursor: 'pointer' }} key={ 'none' } onClick={ close }>{translate('PHRASE_NO_SPECIAL')}</div>);

diff --git a/src/app/components/SlotSection.jsx b/src/app/components/SlotSection.jsx
@@ -15,6 +15,8 @@ export default class SlotSection extends TranslatedComponent {
   static propTypes = {
     ship: PropTypes.object.isRequired,
     onChange: PropTypes.func.isRequired,
+    onCargoChange: PropTypes.func.isRequired,
+    onFuelChange: PropTypes.func.isRequired,
     code: PropTypes.string.isRequired,
     togglePwr: PropTypes.func
   };
@@ -129,44 +131,46 @@ export default class SlotSection extends TranslatedComponent {
     let { originSlot, targetSlot, copy } = this.state;
     let m = originSlot.m;
 
-    if (copy) {
-      // We want to copy the module in to the target slot
-      if (targetSlot && canMount(this.props.ship, targetSlot, m.grp, m.class)) {
-        const mCopy = m.clone();
-        this.props.ship.use(targetSlot, mCopy, false);
-        // Copy power info
-        targetSlot.enabled = originSlot.enabled;
-        targetSlot.priority = originSlot.priority;
-        this.props.onChange();
-      }
-    } else {
-      // Store power info
-      const originEnabled = targetSlot.enabled;
-      const originPriority = targetSlot.priority;
-      const targetEnabled = originSlot.enabled;
-      const targetPriority = originSlot.priority;
-      // We want to move the module in to the target slot, and swap back any module that was originally in the target slot
-      if (targetSlot && m && canMount(this.props.ship, targetSlot, m.grp, m.class)) {
-        // Swap modules if possible
-        if (targetSlot.m && canMount(this.props.ship, originSlot, targetSlot.m.grp, targetSlot.m.class)) {
-          this.props.ship.use(originSlot, targetSlot.m, true);
-          this.props.ship.use(targetSlot, m);
-          // Swap power
-          originSlot.enabled = originEnabled;
-          originSlot.priority = originPriority;
-          targetSlot.enabled = targetEnabled;
-          targetSlot.priority = targetPriority;
-        } else { // Otherwise empty the origin slot
-          // Store power
-          const targetEnabled = originSlot.enabled;
-          this.props.ship.use(originSlot, null, true);  // Empty but prevent summary update
-          this.props.ship.use(targetSlot, m);
-          originSlot.enabled = 0;
-          originSlot.priority = 0;
-          targetSlot.enabled = targetEnabled;
-          targetSlot.priority = targetPriority;
+    if (targetSlot && originSlot != targetSlot) {
+      if (copy) {
+        // We want to copy the module in to the target slot
+        if (targetSlot && canMount(this.props.ship, targetSlot, m.grp, m.class)) {
+          const mCopy = m.clone();
+          this.props.ship.use(targetSlot, mCopy, false);
+          // Copy power info
+          targetSlot.enabled = originSlot.enabled;
+          targetSlot.priority = originSlot.priority;
+          this.props.onChange();
+        }
+      } else {
+        // Store power info
+        const originEnabled = targetSlot.enabled;
+        const originPriority = targetSlot.priority;
+        const targetEnabled = originSlot.enabled;
+        const targetPriority = originSlot.priority;
+        // We want to move the module in to the target slot, and swap back any module that was originally in the target slot
+        if (targetSlot && m && canMount(this.props.ship, targetSlot, m.grp, m.class)) {
+          // Swap modules if possible
+          if (targetSlot.m && canMount(this.props.ship, originSlot, targetSlot.m.grp, targetSlot.m.class)) {
+            this.props.ship.use(originSlot, targetSlot.m, true);
+            this.props.ship.use(targetSlot, m);
+            // Swap power
+            originSlot.enabled = originEnabled;
+            originSlot.priority = originPriority;
+            targetSlot.enabled = targetEnabled;
+            targetSlot.priority = targetPriority;
+          } else { // Otherwise empty the origin slot
+            // Store power
+            const targetEnabled = originSlot.enabled;
+            this.props.ship.use(originSlot, null, true);  // Empty but prevent summary update
+            this.props.ship.use(targetSlot, m);
+            originSlot.enabled = 0;
+            originSlot.priority = 0;
+            targetSlot.enabled = targetEnabled;
+            targetSlot.priority = targetPriority;
+          }
+          this.props.onChange();
         }
-        this.props.onChange();
       }
     }
     this.setState({ originSlot: null, targetSlot: null, copy: null });

diff --git a/src/app/components/StandardSlotSection.jsx b/src/app/components/StandardSlotSection.jsx
@@ -28,6 +28,8 @@ export default class StandardSlotSection extends SlotSection {
   _optimizeStandard() {
     this.props.ship.useLightestStandard();
     this.props.onChange();
+    this.props.onCargoChange(this.props.ship.cargoCapacity);
+    this.props.onFuelChange(this.props.ship.fuelCapacity);
     this._close();
   }
 
@@ -39,6 +41,8 @@ export default class StandardSlotSection extends SlotSection {
   _multiPurpose(shielded, bulkheadIndex) {
     ShipRoles.multiPurpose(this.props.ship, shielded, bulkheadIndex);
     this.props.onChange();
+    this.props.onCargoChange(this.props.ship.cargoCapacity);
+    this.props.onFuelChange(this.props.ship.fuelCapacity);
     this._close();
   }
 
@@ -49,6 +53,8 @@ export default class StandardSlotSection extends SlotSection {
   _optimizeCargo(shielded) {
     ShipRoles.trader(this.props.ship, shielded);
     this.props.onChange();
+    this.props.onCargoChange(this.props.ship.cargoCapacity);
+    this.props.onFuelChange(this.props.ship.fuelCapacity);
     this._close();
   }
 
@@ -59,6 +65,8 @@ export default class StandardSlotSection extends SlotSection {
   _optimizeMiner(shielded) {
     ShipRoles.miner(this.props.ship, shielded);
     this.props.onChange();
+    this.props.onCargoChange(this.props.ship.cargoCapacity);
+    this.props.onFuelChange(this.props.ship.fuelCapacity);
     this._close();
   }
 
@@ -69,6 +77,8 @@ export default class StandardSlotSection extends SlotSection {
   _optimizeExplorer(planetary) {
     ShipRoles.explorer(this.props.ship, planetary);
     this.props.onChange();
+    this.props.onCargoChange(this.props.ship.cargoCapacity);
+    this.props.onFuelChange(this.props.ship.fuelCapacity);
     this._close();
   }
 
@@ -78,6 +88,8 @@ export default class StandardSlotSection extends SlotSection {
   _optimizeRacer() {
     ShipRoles.racer(this.props.ship);
     this.props.onChange();
+    this.props.onCargoChange(this.props.ship.cargoCapacity);
+    this.props.onFuelChange(this.props.ship.fuelCapacity);
     this._close();
   }
 

diff --git a/src/app/i18n/es.js b/src/app/i18n/es.js
@@ -46,7 +46,7 @@ export const terms = {
   'cr': 'Compartimento de carga',
   'cs': 'Esc\u00e1ner de carga',
   'cells': 'celdas',
-  'Chaff Launcher': 'Lanzador de birutas',
+  'Chaff Launcher': 'Lanzador de virutas',
   'close': 'Cerrar',
   'cc': 'Controlador de Drones de Recogida',
   'compare': 'Comparar',