Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github API for downloading the diff #278

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Sep 8, 2024

required for downloading from a private repo using a github token.

Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @smoors !

@trz42 trz42 merged commit 6f4eb2b into EESSI:develop Sep 9, 2024
7 checks passed
@boegel
Copy link
Contributor

boegel commented Sep 9, 2024

@smoors I don't see how this helps for private repos, wasn't that the point of looking into this?

@smoors
Copy link
Contributor Author

smoors commented Sep 9, 2024

@smoors I don't see how this helps for private repos, wasn't that the point of looking into this?

both curl and git (via libcurl) support using github tokens stored in the ~/.netrc file.
however, that doesn't work to download the diff unless you use the github API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants