Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set $EESSI_SILENT #27

Merged
merged 1 commit into from
Oct 4, 2024
Merged

don't set $EESSI_SILENT #27

merged 1 commit into from
Oct 4, 2024

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Oct 4, 2024

I just spent some time trying to figure out why the EESSI init script was only producing this when using in a GitHub Actions workflow:

Environment set up to use EESSI (2023.06), have fun!

It took me a while to realize that this was because $EESSI_SILENT was set somehow.
And then it took me some more time to figure out what was setting $EESSI_SILENT... :)

I don't see the point for suppressing output produced by the init script in the context of a GitHub Actions workflow, why would we use a different default there than what the init script does?

@ocaisa
Copy link
Member

ocaisa commented Oct 4, 2024

@boegel This has conflicts as you based it off an old commit...but also this is really a personal preference (with mine being different to yours 😛 ).

My plan is actually to move to using the module files for initiating EESSI to add more flexibility and make it optional whether the EESSI module is loaded or not when the action is triggered

@boegel
Copy link
Contributor Author

boegel commented Oct 4, 2024

@ocaisa Migrating towards using the module makes sense, but we should there probably start supporting $EB_VERBOSE?

I like getting the output, it helps me double-check and catch issue early on.

And especially in GitHub Actions, I think it's useful. A couple of extra lines of output don't exactly get in the way in that environment?

@ocaisa ocaisa merged commit 00d5545 into EESSI:main Oct 4, 2024
2 checks passed
@ocaisa
Copy link
Member

ocaisa commented Oct 4, 2024

You mean implement an EESSI_VERBOSE? This action is more about the EESSI environment than the EasyBuild settings (which I see being handled by EESSI-extend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants