Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LAMMPS tests to EESSI test-suite #131
Add LAMMPS tests to EESSI test-suite #131
Changes from 28 commits
9a86786
b80e3f2
f07c81a
d0818d0
78c3780
332c5fd
3e2f1af
b7d1548
0656d2f
e777ddb
8a8f838
afe68b1
868375a
36a5dbf
cd93e6c
fbffb2d
aaadf7d
0db87cd
3d47b60
c0b95c7
b025d04
79b02bf
98099ea
0edf80e
dac699c
5b89fd2
9acd2e5
485aafa
fbadd82
acd7da0
4cbacb5
03ed65d
15fb164
dd8a821
65f0c3b
e6b4b5d
7bd0131
d2bf54d
f6b2c5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look right, this is the %CPU usage.
performance should be one of the following:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance: 205379.307 tau/day, 475.415 timesteps/s, 15.213 Matom-step/s
this than?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your line comes from the
lj
test, while mine comes from therhodo
test.let's take
timesteps/s
, as this unit is available for both tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now added
tau/day
forlj
andns/day
forrhodo
but I can also take the timestepsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just checked, and both
tau/day
for lj andns/day
for rhodo scale in exactly the same way astimesteps/s
, so it doesn't really matter.i do have a slight preference for
timesteps/s
as it is easy to understand. otherwise, can you add a comment explaining what exactlytau/day
means?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also do not know what
tau/day
is and google does not have a ready explanation. So changed it to thetimesteps/s
forlj
andrhodo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder for me to also look at this one again