Major/410 session update #395

Treesarj · 2024-02-20T08:22:43Z

Description:

Type of change:

Bug fix.
New feature.
Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

Is the change limited to one issue?
Does this PR close the issue?
Is the code easy to read and understand?
Do all new feature have an accompanying new test?
Has the documentation been updated as necessary?

…arse strategies

Dockerfile

app/models/session.py

app/routers/dataresource.py

app/routers/mapping.py

composerun.py

docker-compose_dev.yml

entrypoint.sh

requirements.txt

test.ttl

Co-authored-by: Casper Welzel Andersen <[email protected]>

…i-services into major/410-session-update

app/routers/mapping.py

app/routers/parser.py

tests/routers/test_parser.py

tests/routers/test_resource.py

tests/static/test_strategies/download.py

tests/static/test_strategies/parse.py

tests/static/test_strategies/resource.py

Co-authored-by: Casper Welzel Andersen <[email protected]>

…pdate

codecov · 2024-02-28T13:08:48Z

Codecov Report

Attention: Patch coverage is 90.82126% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 78.64%. Comparing base (8d43a82) to head (257fe9f).

Files	Patch %	Lines
app/routers/session.py	76.19%	5 Missing ⚠️
app/redis_cache/_cache.py	78.57%	3 Missing ⚠️
app/routers/parser.py	94.64%	3 Missing ⚠️
app/routers/transformation.py	87.50%	3 Missing ⚠️
app/routers/dataresource.py	91.66%	2 Missing ⚠️
app/routers/datafilter.py	94.44%	1 Missing ⚠️
app/routers/function.py	94.44%	1 Missing ⚠️
app/routers/mapping.py	94.73%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #395       +/-   ##
===========================================
+ Coverage   59.47%   78.64%   +19.16%     
===========================================
  Files          20       23        +3     
  Lines         728      693       -35     
===========================================
+ Hits          433      545      +112     
+ Misses        295      148      -147

Flag	Coverage Δ
pytest	`78.64% <90.82%> (+19.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CasperWA · 2024-02-28T13:16:00Z

The docker-compose CI tests are currently failing due to bc04d82. This commit should be reverted and the oteapi-core dependency should be updated to point to the soon-to-be-released oteapi-core latest version, which includes the changes from EMMC-ASBL/oteapi-core#429.

Note: When installing locally the requirements.txt via 'pip install' remember to use the '--pre' option. Fix the regex in 'entrypoint.sh' to allow for "weird" versions of oteapi-core in requirements.txt.

Expose debug port in development Dockerfile target. Hopefully this fixes the docker-compose development CI.

CasperWA

Minor things only

app/routers/dataresource.py

app/routers/mapping.py

app/routers/parser.py

app/routers/session.py

tests/conftest.py

Co-authored-by: Casper Welzel Andersen <[email protected]>

Mention the current use of a development version of oteapi-core.

* Use v0.7.0.dev0 of oteapi-core * modify the endpoints to handle the absence of a session. * add parser APIs * update tests * update readme Co-authored-by: Thomas Hagelien <[email protected]> Co-authored-by: Casper Welzel Andersen <[email protected]>

Thomas Hagelien and others added 11 commits February 1, 2024 10:50

WIP

1d35875

Add test_parser and update session delete

93bdde6

Updated the dataresource. Removed instantiation of the download and p…

2f9b8c5

…arse strategies

fix parser API to fetch from session

608b2d5

add checks and fix initialize in dataresource strategy

c8ebc22

modify parser API's

203eccc

Add initialize endpoint for parser

d50f461

rename endpoint

f691179

fix pre-commit errors

65b03cf

Merge branch 'master' into major/410-session-update

74a737d

fix pre-commit

55cd80e

CasperWA requested changes Feb 21, 2024

View reviewed changes

Merge branch 'master' into major/410-session-update

89863f2

Treesarj linked an issue Feb 21, 2024 that may be closed by this pull request

Separate parse and download #55

Closed

Treesarj and others added 8 commits February 22, 2024 15:08

updated tests and new test for dataresource

454e17b

Update app/models/session.py

8ecc76a

Co-authored-by: Casper Welzel Andersen <[email protected]>

Update app/routers/session.py

cedc8ef

Co-authored-by: Casper Welzel Andersen <[email protected]>

resolve comments

9d52802

Merge branch 'major/410-session-update' of github.com:EMMC-ASBL/oteap…

344645f

…i-services into major/410-session-update

fix test configuration

1a45ab7

fix tests

d6d6a88

requested changes

ba5c771

CasperWA requested changes Feb 23, 2024

View reviewed changes

Treesarj and others added 7 commits February 23, 2024 14:44

Update tests/static/test_strategies/resource.py

65f9eff

Co-authored-by: Casper Welzel Andersen <[email protected]>

remove test ttl file and debug.py from requirements.txt

5541e93

requested changes

aee3cf5

move cache key validation

e0786d7

requested changes

5a7bc1e

redo fetch cache key

759aebd

requested changes

f4aa22a

Treesarj added 2 commits February 27, 2024 09:37

fix pylint errors

24d0237

fix pylint errors

94cf49c

Treesarj requested a review from CasperWA February 27, 2024 08:50

CasperWA added 7 commits February 27, 2024 14:29

Remove unused imports

968b0f3

Satisfy pre-commit hooks

2ae97b0

Temporarily use the latest developments in oteapi-core

bc04d82

Do not show coverage on failed test runs

25e8deb

Add session merging tests to all router tests

d3eb4c8

Update dumping dataresouce config in test

7aceaa7

Merge remote-tracking branch 'origin/master' into major/410-session-u…

a25ae0f

…pdate

CasperWA added 4 commits February 29, 2024 15:37

Use v0.7.0.dev0 of oteapi-core

7181f95

Note: When installing locally the requirements.txt via 'pip install' remember to use the '--pre' option. Fix the regex in 'entrypoint.sh' to allow for "weird" versions of oteapi-core in requirements.txt.

Update docker-compose_ci_plugin.yml

3cef560

Expose debug port in development Dockerfile target. Hopefully this fixes the docker-compose development CI.

Try avoiding running debugpy

bfb6ff0

Revert changed sleep in CI

6b57b1d

CasperWA requested changes Feb 29, 2024

View reviewed changes

CasperWA and others added 3 commits February 29, 2024 20:41

Remove logging setup in tests

306c0ed

Update app/routers/session.py

0e1213a

Co-authored-by: Casper Welzel Andersen <[email protected]>

requested changes

0ad16f0

Treesarj requested a review from CasperWA March 1, 2024 08:33

CasperWA approved these changes Mar 1, 2024

View reviewed changes

Update README with important notice

257fe9f

Mention the current use of a development version of oteapi-core.

CasperWA enabled auto-merge (squash) March 1, 2024 09:07

CasperWA merged commit f92b9d4 into master Mar 1, 2024
10 checks passed

CasperWA deleted the major/410-session-update branch March 1, 2024 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Major/410 session update #395

Major/410 session update #395

Treesarj commented Feb 20, 2024

codecov bot commented Feb 28, 2024 •

edited

Loading

CasperWA commented Feb 28, 2024

CasperWA left a comment

Major/410 session update #395

Major/410 session update #395

Conversation

Treesarj commented Feb 20, 2024

Description:

Type of change:

Checklist for the reviewer:

codecov bot commented Feb 28, 2024 • edited Loading

Codecov Report

CasperWA commented Feb 28, 2024

CasperWA left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 28, 2024 •

edited

Loading