refactor: add expections for N1081B and add tests for it

src/daq/base.py

@@ -1,7 +1,7 @@
 import logging
 import threading
 from dataclasses import dataclass
-from queue import Queue
+from queue import Empty, Queue
 from typing import Any
 
 from daq.models import DAQJobMessage, DAQJobMessageStop, DAQJobStopError
@@ -25,10 +25,13 @@ def __init__(self, config: Any):
 
     def consume(self):
         # consume messages from the queue
-        while not self.message_in.empty():
-            message = self.message_in.get()
-            if not self.handle_message(message):
-                self.message_in.put_nowait(message)
+        while True:
+            try:
+                message = self.message_in.get_nowait()
+                if not self.handle_message(message):
+                    self.message_in.put_nowait(message)
+            except Empty:
+                break
 
     def handle_message(self, message: "DAQJobMessage") -> bool:
         if isinstance(message, DAQJobMessageStop):

src/daq/caen/n1081b.py

@@ -48,6 +48,7 @@ def start(self):
             if not self._is_connected():
                 self._logger.info("Connecting to the device...")
                 self._connect_to_device()
+                self._logger.info("Connected!")
 
             # Poll sections
             self._poll_sections()
@@ -70,12 +71,11 @@ def _poll_sections(self):
 
             res = self.device.get_function_results(section)
             if not res:
-                continue
+                raise Exception("No results")
 
             data = res["data"]
             if "counters" not in data:
-                self._logger.info(f"No counters in section {section}")
-                continue
+                raise Exception(f"No counters in section {section}")
 
             self._send_store_message(data, section.name)
 

src/tests/test_n1081b.py

@@ -53,7 +53,9 @@ def test_poll_sections(self, mock_get_function_results):
     @patch.object(N1081B, "get_function_results", return_value={"data": {}})
     def test_poll_sections_no_counters(self, mock_get_function_results):
         self.daq_job._send_store_message = MagicMock()
-        self.daq_job._poll_sections()
+        with self.assertRaises(Exception) as context:
+            self.daq_job._poll_sections()
+        self.assertTrue("No counters in section" in str(context.exception))
         self.daq_job._send_store_message.assert_not_called()
 
     @patch("time.sleep", return_value=None, side_effect=StopIteration)
@@ -71,7 +73,9 @@ def test_start(
     @patch.object(N1081B, "get_function_results", return_value=None)
     def test_poll_sections_no_results(self, mock_get_function_results):
         self.daq_job._send_store_message = MagicMock()
-        self.daq_job._poll_sections()
+        with self.assertRaises(Exception) as context:
+            self.daq_job._poll_sections()
+        self.assertTrue("No results" in str(context.exception))
         self.daq_job._send_store_message.assert_not_called()
 
     @patch.object(