Fixed infinite api calls in a story #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
fixes #105
Describe the changes you've made
I have added the React
useEffect
hook in thecommentForm
component where all the users of the application are fetched. Previously, without the hook, the state was updated at each call, and this caused the component to re-render for every call. This led to infinite API calls to the backend. After this fix a request is made to the backend only once which is sufficient to fetch all the users.Describe if there is any unusual behavior (Any Warning) of your code(Write
NA
if there isn't)NA
Additional context (OPTIONAL)
NA
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
NA
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route
NA