-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #97: Added delete feature in a story #128
base: main
Are you sure you want to change the base?
Conversation
@mharshita |
This is a great work, the only thing is that we don't want to allow users to delete a story. We made this decision in the past to consider that stories may have information from other users supporting a request (screenshots, votes, additional information, etc), so only an admin should be able to delete a story either because it is inappropriate or invalid. But a user shouldn't have this option. What we could do, is that a user reports a story to be deleted and that it triggers on the admin to be reviewed. What do you think @kailash360 ? Could you change the implementation to go in this direction instead? |
Sure, we can replace the I have thought of the following approach to this:
Kindly suggest if there is any other approach, or if I should start implementing this approach. |
|
@kailash360 after the implementation of the Reporting model on Strapi, have you followed up to create a Report feature on the front-end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've decided that we will only use Reports, as opposed to delete, since it goes against the use cases of the application to let users delete a story
@cyntss We can close this PR, and I'll open another one that will add the Report modal displayed above. |
Issue Number
fixes #97
Describe the changes you've made
I have added the service to make a request of DELETE method, and also modified the apiCall function such that it can accommodate any request method. I have also added a Delete button in the page of a story tha the user can sue to delete a story.
Describe if there is any unusual behavior (Any Warning) of your code(Write
NA
if there isn't)NA
Additional context (OPTIONAL)
NA
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route
screen-capture.1.mp4