Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added accept attribute for img only #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codetheorem
Copy link
Member

@codetheorem codetheorem commented Mar 24, 2022

Issue Number

fixes #189

Describe the changes you've made

Added accept attribute so that any user can only upload image files in comment.

Test plan (OPTIONAL)

  1. Go to a story.
  2. click on attachment icon in comment form.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Signed-off-by: Hrishikesh Agarwal <[email protected]>
@cyntss
Copy link
Member

cyntss commented Jul 26, 2022

In some cases, we will need to have other types of files, such as PDF or word documents if someone needs to provide full documentation. Could you update the PR to reflect these file types? also, it would be great to add some sort of information pop-up to show the users the type of files accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All files getting accepted in file explorer
2 participants