Fix inconsistent alignment in Language button and Fix Story description overlapping footer contents, if description text is large #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
fixes #173
fixes #178
Describe the changes you've made
#173
Removed classes on
<EOS_KEYBOARD_ARROW_UP />
,<EOS_KEYBOARD_ARROW_DOWN />
components, along with the class on div that holds the stringLanguage
so that inconsistent margin/padding is eliminated.#178
Replaced absolute viewport height of story page to
100%
to contain the expanded story description and avoid overlapping and overflowing, and also setting the height to100%
ensures it occupies the full screen giving it the same behavior as100vh
.Additionally, I've also reordered the properties of
.options-bar
class ofhome.scss
prior to which the tests were failing due to incorrect lexical ordering of the class properties.Describe if there is any unusual behavior (Any Warning) of your code(Write
NA
if there isn't)NA
Additional context (OPTIONAL)
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
Manual testing:
Show more
and scroll all the way to the bottom. You should notice that the footer content is not overlapping any of the story components.Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route