Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update surface albedo in TUV-x prior to calculating rate constants #141

Merged
merged 22 commits into from
Oct 30, 2024

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Oct 18, 2024

Originator(s): @mattldawson, @boulderdaze

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:

  • A schemes/musica/tuvx/musica_ccpp_tuvx_surface_albedo.F90
  • A schemes/musica/tuvx/musica_ccpp_tuvx_util.F90
  • A schemes/musica/tuvx/musica_ccpp_tuvx_wavelength_grid.F90
  • A test/musica/tuvx/test_tuvx_surface_albedo.F90
  • A test/musica/tuvx/test_tuvx_wavelength_grid.F90

List all existing files that have been modified, and describe the changes:

  • M schemes/musica/musica_ccpp.F90
  • M schemes/musica/musica_ccpp.meta
  • M schemes/musica/tuvx/musica_ccpp_tuvx.F90
  • M test/musica/micm/test_micm_util.F90
  • M test/musica/test_musica_api.F90
  • M test/musica/tuvx/CMakeLists.txt
  • M test/musica/tuvx/configs/ts1_tsmlt.json
  • M test/musica/tuvx/test_tuvx_height_grid.F90
  • M test/musica/tuvx/test_tuvx_temperature.F90

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

@boulderdaze boulderdaze self-assigned this Oct 18, 2024
@boulderdaze boulderdaze marked this pull request as ready for review October 25, 2024 21:37
@boulderdaze boulderdaze requested review from nusbaume, mattldawson, jimmielin and K20shores and removed request for mattldawson October 25, 2024 21:40
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boulderdaze! This looks good to me, I have a few minor comments.

schemes/musica/musica_ccpp.F90 Outdated Show resolved Hide resolved
schemes/musica/tuvx/musica_ccpp_tuvx.F90 Show resolved Hide resolved
test/musica/tuvx/test_tuvx_surface_albedo.F90 Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@boulderdaze boulderdaze merged commit 862ac09 into development Oct 30, 2024
2 checks passed
@boulderdaze boulderdaze deleted the 96-update-surface-albedo branch October 30, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants