Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin mamba in conda lock creation github action #2561

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 21, 2024

Description

Related to ESMValGroup/ESMValTool#3782 - currently conda-lock is struggling with mamba>=2 but Ben Mares at conda-lock has fixed the issue, and all we need to do is wait for a major release of conda-lock; in the meantime the workaround is to pin mamba in the Github action, so we can get our lock file generated.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (f622e40) to head (16c762a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2561   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         251      251           
  Lines       14266    14266           
=======================================
  Hits        13520    13520           
  Misses        746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to point the comments in Tool and Core to the same pull request? right now it's diff ones.

@valeriupredoi
Copy link
Contributor Author

cheers @bettina-gier - good point, the issue I am pointing to here is actually a more up to date one, for Tool I'd have to open yet another PR to get that in in a comment, and by now, I reckon you've had enough of these reviews, so I don't want to scare off our new techie bod 😁

@valeriupredoi
Copy link
Contributor Author

but - excellent review BTW - this is what we want - reviewers to pay attention to all the details, not like me - approve a Draft PR 🤣

@bettina-gier
Copy link
Contributor

if you're just changing the link in the tool I can approve it without having to think, so all good. Better to be consistent than to save those 5min

@valeriupredoi
Copy link
Contributor Author

if you're just changing the link in the tool I can approve it without having to think, so all good. Better to be consistent than to save those 5min

sounds good - let me do that after I merge this 😃

@valeriupredoi valeriupredoi merged commit 4526c84 into main Oct 21, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the temp_pin_mamba_condalock branch October 21, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants