Bazel: Support bazel build for essential modules #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should go only after this one EVerest/everest-framework#162 Before merging we should switch the everest-framework reference to new revision in everest/core/main |
golovasteek
force-pushed
the
bazel/support_bazel_build_for_essential_modules
branch
2 times, most recently
from
87f7672
to
97bdd0b
Compare
golovasteek
force-pushed
the
bazel/support_bazel_build_for_essential_modules
branch
3 times, most recently
from
82a75f5
to
c88129c
Compare
hikinggrass
reviewed
Apr 5, 2024
golovasteek
force-pushed
the
bazel/support_bazel_build_for_essential_modules
branch
from
fd1dea1
to
155fa54
Compare
Signed-off-by: Evgeny Petrov <[email protected]>
golovasteek
force-pushed
the
bazel/support_bazel_build_for_essential_modules
branch
2 times, most recently
from
92b7b7a
to
35ba072
Compare
Signed-off-by: Evgeny Petrov <[email protected]>
golovasteek
force-pushed
the
bazel/support_bazel_build_for_essential_modules
branch
from
35ba072
to
c365778
Compare
golovasteek
requested review from
SirVer,
dorezyuk,
Pietfried and
corneliusclaussen
as code owners
|
This is so nice and pretty, I think I am crying a little bit. |
SirVer
approved these changes
Apr 22, 2024
Signed-off-by: Evgeny Petrov <[email protected]>
golovasteek
force-pushed
the
bazel/support_bazel_build_for_essential_modules
branch
from
86c7a13
to
df3e706
Compare
dorezyuk
approved these changes
Apr 23, 2024
hikinggrass
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In this MR we introduce Bazel build annotations, for the essential.
There is a
everest_cc_modulerule introduced that is used for the module declaration.The aim of this PR is to create basic infrastructure for the module builds.
The bazel support is still experimental and maintained at best-effort basis.
Issue ticket number and link
Checklist before requesting a review
TODO before merge: