RsIskraMeter: Initial commit #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 7, 2024 10:36
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
dorezyuk
force-pushed
the
feat/rs_iskra_meter
branch
from
396233f
to
23f6d3a
Compare
added 4 commits
March 7, 2024 10:40
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
dorezyuk
requested review from
SirVer,
Pietfried,
corneliusclaussen and
hikinggrass
as code owners
SirVer
reviewed
Mar 15, 2024
SirVer
approved these changes
Mar 15, 2024
|
@corneliusclaussen @Pietfried @hikinggrass This is supporting the Iskra Meter, including everything needed for german eichrecht (i.e. signed meter values). We use this one in production and would like to contribute to the eco system. @caller fyi |
|
@dorezyuk this needs merging of main. |
hikinggrass
previously requested changes
Mar 15, 2024
lategoodbye
reviewed
Mar 15, 2024
lategoodbye
reviewed
Mar 15, 2024
lategoodbye
requested changes
Mar 15, 2024
added 2 commits
March 15, 2024 16:16
Signed-off-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
dorezyuk
commented
Mar 18, 2024
| signing_method: "OCMF".to_string(), | ||
| encoding_method: String::new(), | ||
| public_key: self.read_public_key().ok(), | ||
| timestamp: None, |
There was a problem hiding this comment.
@hikinggrass @golovasteek should we set also the tiemstamps?
There was a problem hiding this comment.
Generally it makes sense for consistency, but only if we decode the OCMF string and take it from there.
dorezyuk
commented
Mar 18, 2024
golovasteek
reviewed
Mar 18, 2024
dorezyuk
commented
Mar 18, 2024
Signed-off-by: Dima Dorezyuk <[email protected]>
lategoodbye
approved these changes
Mar 18, 2024
Signed-off-by: Dima Dorezyuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr adds support for Iskra's WM3M4 & WM3M4C power meters