fix: not all SessionEventEnum mapped to SessionInfo::State #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EVerest API session_info topic wasn't aways representing state
since some cases in types::evse_manager::SessionEventEnum were
missing from the if {...} else if {...} chain.
Moved to a switch so that analysis tools can spot future missing
cases.
'PrepareCharging' was missing, included in the new switch.
Signed-off-by: James Chapman <[email protected]>
hikinggrass
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The EVerest API session_info topic wasn't aways representing state since some cases in types::evse_manager::SessionEventEnum were missing from the if {...} else if {...} chain.
Moved to a switch so that analysis tools can spot future missing cases.
'PrepareCharging' was missing, included in the new switch.
Issue ticket number and link
Checklist before requesting a review