connector inoperative overridden #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
james-ctc
force-pushed
the
fix/connector-inoperative-overridden
branch
from
a6e48bc
to
3a0f1b6
Compare
james-ctc
requested review from
hikinggrass,
Pietfried,
corneliusclaussen and
SebaLukas
as code owners
barsnick
reviewed
May 16, 2024
barsnick
reviewed
May 16, 2024
It replaces the old enable/disable commands and adds a source and priority. See README of the API module for more details. Compile time breaking change on the evse_manager interface. All enable/disable calls need to be switched over to the new enable_disable call, for everest-core this is done in this PR. In some uses cases it is useful if e.g. a LocalAPI source disables a connector that only the same local source can enable again. Think of a service technician who has an app to disable the connector locally. Then it should be prevented that it is re-enabled by the CSMS until the service technician enables it again via the same app. Using priorities this is quite flexible and a lot of use-cases can be implemented without a change in EVerest code. The API module also has a new enable_disable command. It also has compatibility implementations for the old enable/disable commands. Signed-off-by: Cornelius Claussen <[email protected]> fix: merge issues fix: updated README Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
james-ctc
force-pushed
the
fix/connector-inoperative-overridden
branch
from
91f4e73
to
451ee5d
Compare
Pietfried
force-pushed
the
feature/enable_disable_source
branch
2 times, most recently
from
b0b0f7b
to
dbc8527
Compare
|
This issue has been adressed by: #714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When OCPP ChangeConfiguration to Inoperative is set this is overridden on EVerest restart.
In addition some actions on the CP line were causing the state to leave DISABLED.
This work is based upon:
#505
This changed is linked with
EVerest/libocpp#623
Issue ticket number and link
Checklist before requesting a review