Remove deprecated BSM powermeter module #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
Pietfried,
hikinggrass,
SirVer,
golovasteek and
dorezyuk
as code owners
golovasteek
approved these changes
Oct 8, 2024
mhei
approved these changes
Oct 8, 2024
hikinggrass
approved these changes
Oct 8, 2024
hikinggrass
changed the title
dorezyuk
approved these changes
Oct 31, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
cleanup/remove-powermeter-bsm
branch
from
35ed9d4
to
7b000e7
Compare
SirVer
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The PowermeterBSM module does not use the SerialCommHub, so it cannot be used with other modules on the same modbus. It also adds an extra dependency for EVerest to the libmodbus, which causes trouble from time to time because another library with the same name exists.
Support for Eichrecht is broken in the module limiting its use quite a bit. If we still need support for this powermeter it should be re-written, using the the SerialCommHub and a proper Eichrecht implementation.
Issue ticket number and link
Checklist before requesting a review