Feature/pn7160 token prov ext lib #951
Conversation
cburandt
requested review from
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
dependencies.yaml
Outdated
| # linux_libnfc-nci for RFID | ||
| libnfc-nci: | ||
| git: https://github.com/EVerest/linux_libnfc-nci.git | ||
| git_tag: 202411.1.0 |
There was a problem hiding this comment.
Just a minor observation, for consistency with the other repos that use a date based version this could be 2024.11.0 (since it's date based it's not a semantic version anyway)
There was a problem hiding this comment.
Can also have a
cmake_condition: "EVEREST_DEPENDENCY_ENABLED_LIBNFC_NCI"
There was a problem hiding this comment.
A find_package somewhere around here needs to be added as well:
Line 111 in 5cc8b6d
There was a problem hiding this comment.
Since I don't know in which situation it would be used: Is a BUILD.libnfc_nci.bazel required?
There was a problem hiding this comment.
With this entry:
everest-core/module-dependencies.cmake
Line 65 in ab1bb79
There was a problem hiding this comment.
I'm not sure here, but these files are copied from somewhere, and hence we should check and indicate their licensing.
There was a problem hiding this comment.
They are Apache-2.0-licensed. I will add according headers to them.
| this->callback = std::move(callback_); | ||
|
|
||
| registerTagCallback(&nfc_callbacks); | ||
| doEnableDiscovery(DEFAULT_NFA_TECH_MASK, 0x01, 0x0, 0x1); |
There was a problem hiding this comment.
This line would benefit from some more explicit documentation about the flags
cburandt
force-pushed
the
feature/PN7160TokenProv-extLib
branch
from
10f8250
to
ab1bb79
Compare
cburandt
force-pushed
the
feature/PN7160TokenProv-extLib
branch
from
530394c
to
c5d8fbf
Compare
Signed-off-by: Christoph Burandt <[email protected]>
- add missing find_package in top-level CMakeLists.txt - fix Version no. in dependencies.yaml - fix clang-format violations - add license headers to libnfc-nci config files - add explaining comment to nfc discovery ininitialization - use cmake property to extract config install path from libnfc_nci Signed-off-by: Christoph Burandt <[email protected]>
Signed-off-by: Christoph Burandt <[email protected]>
cburandt
force-pushed
the
feature/PN7160TokenProv-extLib
branch
from
c5d8fbf
to
b143c62
Compare
Add module for NXP PN7160 NFC chip as token provider.
Adds EVerest/linux_libnfc-nci (forked from NXPNFCLinux and patched to work well with EVerest).