Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlacSimulator initialize state with UNMATCHED #963

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

hikinggrass
Copy link
Contributor

This could publish an empty string on startup while an enum was expected, leading to failures when running EVerest with schema validation enabled

remove default empty string from state_to_string
enable -Werror=switch-enum for SlacSimulator module

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

This could publish an empty string on startup while an enum was expected, leading to failures when running EVerest with schema validation enabled

remove default empty string from state_to_string
enable -Werror=switch-enum for SlacSimulator module

Signed-off-by: Kai-Uwe Hermann <[email protected]>
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well spotted

@hikinggrass hikinggrass merged commit 8280727 into main Nov 14, 2024
11 checks passed
@hikinggrass hikinggrass deleted the bugfix/slac-simulator-uninitialized-state branch November 14, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants