Disconnect websocket also when it is not connected. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mennodegraaf
approved these changes
Feb 12, 2024
| this->ws_client.close(this->handle, websocketpp::close::status::normal, ""); | ||
| } catch (std::exception& e) { | ||
| EVLOG_error << "Error on plain close: " << e.what(); | ||
| if (!this->shutting_down) { |
There was a problem hiding this comment.
What happens if WebsocketBase::disconnect is called just after this line? Will the code after this line still run and is that a problem?
There was a problem hiding this comment.
You mean to add it there? Or in the 'else'? I do not totally understand what you mean.
hikinggrass
approved these changes
Feb 21, 2024
maaikez
force-pushed
the
mz-websocket-connection-stop
branch
from
8eb113a
to
5214913
Compare
…cks. Cancel timer in websocket destructor. Signed-off-by: Maaike Zijderveld <[email protected]> Signed-off-by: Maaike <[email protected]>
…ave a connection Signed-off-by: Maaike Zijderveld <[email protected]> Signed-off-by: Maaike <[email protected]>
Signed-off-by: Maaike <[email protected]>
maaikez
force-pushed
the
mz-websocket-connection-stop
branch
from
5214913
to
72bf117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more checks. Cancel timer in websocket destructor.