408 extend network connection profiles #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcodenBesten
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
maaikez
reviewed
Sep 3, 2024
WilcodenBesten
force-pushed
the
408-extend-network-connection-profiles
branch
from
14d1946
to
4cd31ad
Compare
WilcodenBesten
force-pushed
the
408-extend-network-connection-profiles
branch
from
d81947f
to
f2eb0a4
Compare
maaikez
reviewed
Sep 5, 2024
Merged
2 tasks
|
Looks good, only one question about the timer. I did a short test and it still connects with the CSMS. However, I needed to do some changes in everest core, pull request is here: And let's not forget to close #410 after this pull request is merged. |
maaikez
approved these changes
Sep 5, 2024
WilcodenBesten
force-pushed
the
408-extend-network-connection-profiles
branch
2 times, most recently
from
ab44905
to
82fa594
Compare
WilcodenBesten
commented
Oct 7, 2024
…k connectivity slot info Added on_network_disconnected that will switch to the next network connection profile when invoked Extended the configure network connectivity profile callback with a cpp future / promise mechanism Added networkconnectivity documentation. These were originally added in PR 410 and have been updated to match the current implementation. Added on_try_switch_network_connection_profile function to try to switch to a higher priority network connection profile Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
…ched network profile information as that's helpful when using the newly added optional functions Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
WilcodenBesten
force-pushed
the
408-extend-network-connection-profiles
branch
from
17eae29
to
093cb14
Compare
maaikez
approved these changes
Oct 14, 2024
marcemmers
requested changes
Oct 14, 2024
jannejy
reviewed
Oct 14, 2024
jannejy
reviewed
Oct 16, 2024
Signed-off-by: Wilco den Besten <[email protected]>
Signed-off-by: Wilco den Besten <[email protected]>
marcemmers
reviewed
Oct 23, 2024
marcemmers
approved these changes
Oct 24, 2024
Signed-off-by: Wilco den Besten <[email protected]>
WilcodenBesten
force-pushed
the
408-extend-network-connection-profiles
branch
from
80d0044
to
63b58a7
Compare
Signed-off-by: Wilco den Besten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resolved #408
Issue ticket number and link
Checklist before requesting a review