K01 ChargePoint refactorings #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviceModel and DatabaseHandler were being passed as smart pointers but there is no need for SmartChargingHandler to manage the lifetime of those objects. Instead we pass them as reference to communicate clearly the intent. Signed-off-by: Gianfranco Berardi <[email protected]>
By providing and using a MessageQueueInterface the tests can now use a mock to avoid the cost of the real message queue's initialization, allowing tests to run faster and for tests to be easier to write and maintain. Signed-off-by: Gianfranco Berardi <[email protected]>
gberardi-pillar
force-pushed
the
feature/k01_chargepoint_refactor_continued
branch
from
558deb8
to
b72a6f6
Compare
shankari
suggested changes
Oct 15, 2024
shankari
approved these changes
Oct 15, 2024
gberardi-pillar
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
|
Closed in favor of #849 which will refactor the message dispatching. We will include parts of this PR either there or in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch includes work that updates the ChargePoint constructor to take references instead of shared pointers as parameters, as well as provides a MessageQueueInterface to allow for the creation of a MessageQueueMock, which will make it possible to run tests faster as well as write and maintain tests more easily.
Checklist before requesting a review