-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate OCPP 2.1 public draft messages #845
base: main
Are you sure you want to change the base?
Changes from 19 commits
1abd2bb
780572c
70e7dd7
dd95a43
a882867
17b736e
0492085
59d1361
a3e730f
ab4f806
ce30fc5
cb9e57e
ada40cb
03e55cd
2f0d9f3
a1cc575
5800478
4dfd843
b14ec4b
06b4919
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ namespace v201 { | |
struct AuthorizeRequest : public ocpp::Message { | ||
IdToken idToken; | ||
std::optional<CustomData> customData; | ||
std::optional<CiString<5500>> certificate; | ||
std::optional<CiString<10000>> certificate; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could probably be reported via |
||
std::optional<std::vector<OCSPRequestData>> iso15118CertificateHashData; | ||
|
||
/// \brief Provides the type of this Authorize message as a human readable string | ||
|
@@ -42,6 +42,9 @@ struct AuthorizeResponse : public ocpp::Message { | |
IdTokenInfo idTokenInfo; | ||
std::optional<CustomData> customData; | ||
std::optional<AuthorizeCertificateStatusEnum> certificateStatus; | ||
std::optional<std::vector<EnergyTransferModeEnum>> allowedEnergyTransfer; | ||
std::optional<Tariff> tariff; | ||
std::optional<TransactionLimit> transactionLimit; | ||
|
||
/// \brief Provides the type of this AuthorizeResponse message as a human readable string | ||
/// \returns the message type as a human readable string | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,8 +20,10 @@ namespace v201 { | |
struct Get15118EVCertificateRequest : public ocpp::Message { | ||
CiString<50> iso15118SchemaVersion; | ||
CertificateActionEnum action; | ||
CiString<5600> exiRequest; | ||
CiString<11000> exiRequest; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a |
||
std::optional<CustomData> customData; | ||
std::optional<int32_t> maximumContractCertificateChains; | ||
std::optional<std::vector<CiString<255>>> prioritizedEMAIDs; | ||
|
||
/// \brief Provides the type of this Get15118EVCertificate message as a human readable string | ||
/// \returns the message type as a human readable string | ||
|
@@ -44,6 +46,7 @@ struct Get15118EVCertificateResponse : public ocpp::Message { | |
CiString<ISO15118_GET_EV_CERTIFICATE_EXI_RESPONSE_SIZE> exiResponse; | ||
std::optional<CustomData> customData; | ||
std::optional<StatusInfo> statusInfo; | ||
std::optional<int32_t> remainingContracts; | ||
|
||
/// \brief Provides the type of this Get15118EVCertificateResponse message as a human readable string | ||
/// \returns the message type as a human readable string | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ struct GetCertificateStatusResponse : public ocpp::Message { | |
GetCertificateStatusEnum status; | ||
std::optional<CustomData> customData; | ||
std::optional<StatusInfo> statusInfo; | ||
std::optional<CiString<5500>> ocspResult; | ||
std::optional<CiString<18000>> ocspResult; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a |
||
|
||
/// \brief Provides the type of this GetCertificateStatusResponse message as a human readable string | ||
/// \returns the message type as a human readable string | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ namespace v201 { | |
/// \brief Contains a OCPP InstallCertificate message | ||
struct InstallCertificateRequest : public ocpp::Message { | ||
InstallCertificateUseEnum certificateType; | ||
CiString<5500> certificate; | ||
CiString<10000> certificate; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a |
||
std::optional<CustomData> customData; | ||
|
||
/// \brief Provides the type of this InstallCertificate message as a human readable string | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ namespace v201 { | |
|
||
/// \brief Contains a OCPP PublishFirmware message | ||
struct PublishFirmwareRequest : public ocpp::Message { | ||
CiString<512> location; | ||
CiString<2000> location; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a |
||
CiString<32> checksum; | ||
int32_t requestId; | ||
std::optional<CustomData> customData; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,8 +19,9 @@ namespace v201 { | |
struct PublishFirmwareStatusNotificationRequest : public ocpp::Message { | ||
PublishFirmwareStatusEnum status; | ||
std::optional<CustomData> customData; | ||
std::optional<std::vector<CiString<512>>> location; | ||
std::optional<std::vector<CiString<2000>>> location; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a |
||
std::optional<int32_t> requestId; | ||
std::optional<StatusInfo> statusInfo; | ||
|
||
/// \brief Provides the type of this PublishFirmwareStatusNotification message as a human readable string | ||
/// \returns the message type as a human readable string | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,11 +23,14 @@ struct TransactionEventRequest : public ocpp::Message { | |
int32_t seqNo; | ||
Transaction transactionInfo; | ||
std::optional<CustomData> customData; | ||
std::optional<CostDetails> costDetails; | ||
std::optional<std::vector<MeterValue>> meterValue; | ||
std::optional<bool> offline; | ||
std::optional<int32_t> numberOfPhasesUsed; | ||
std::optional<int32_t> cableMaxCurrent; | ||
std::optional<float> cableMaxCurrent; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't strictly backwards compatible with 2.0.1 and probably needs additional handling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change doesnt seem to make a lot of sense. In We should make sure that the float is serialized to an int in 2.0.1 when transmitting to the CSMS. |
||
std::optional<int32_t> reservationId; | ||
std::optional<PreconditioningStatusEnum> preconditioningStatus; | ||
std::optional<bool> evseSleep; | ||
std::optional<EVSE> evse; | ||
std::optional<IdToken> idToken; | ||
|
||
|
@@ -52,7 +55,9 @@ struct TransactionEventResponse : public ocpp::Message { | |
std::optional<float> totalCost; | ||
std::optional<int32_t> chargingPriority; | ||
std::optional<IdTokenInfo> idTokenInfo; | ||
std::optional<TransactionLimit> transactionLimit; | ||
std::optional<MessageContent> updatedPersonalMessage; | ||
std::optional<std::vector<MessageContent>> updatedPersonalMessageExtra; | ||
|
||
/// \brief Provides the type of this TransactionEventResponse message as a human readable string | ||
/// \returns the message type as a human readable string | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really a backwards-compatible change in the 2.1 schemas. Changes like this happened in a few different messages/types and need case-by-case handling. Either by adding additional conversion functions or different message generation for 2.0.1 and 2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok to accept larger tokens here. This is only an issue if e.g. OCTT tests for OCPP2.0.1 if we accept larger tokens.