Support hashing directories of certificates #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannejy
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
jannejy
force-pushed
the
feature/support_folder_certificates
branch
from
d527a9a
to
0d5a28a
Compare
jannejy
commented
Oct 31, 2024
| @@ -0,0 +1,310 @@ | |||
| /* c_rehash.c - Create hash symlinks for certificates | |||
There was a problem hiding this comment.
This file was taken from: https://gitlab.alpinelinux.org/alpine/ca-certificates/-/blob/master/c_rehash.c?ref_type=heads
Done some changes:
- only the
hash_dirand dependent methods are left - removed all the parameters of command line that are were used in main.
- changed logging to Everest (can be an issue), maybe needed help to overcome static analysis issues
- added explicit C-conversion to compile
- wrapped in the ocpp namespace
- some initialization is moved to
hash_dirto work properly
There was a problem hiding this comment.
Also, it's worth looking together with the PR in evse-security: EVerest/libevse-security#96
3 tasks
jannejy
force-pushed
the
feature/support_folder_certificates
branch
from
0d5a28a
to
6a20562
Compare
Signed-off-by: Ivan Rogach <[email protected]>
jannejy
force-pushed
the
feature/support_folder_certificates
branch
from
6a20562
to
991e73f
Compare
|
In general it looks good to me. I like the fact that there's a conditional to check if we're using a directory or a file, however see my comment in the evse-security PR: EVerest/libevse-security#96 (comment) If it handles that case in security code too, I'll have another look and approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review