Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle 2k3: fixed battler facing direction + horizontal ally/enemy select #3052

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

Primekick
Copy link
Contributor

Those features were originally intended for Lufia V: For the Savior to make it work on EasyRPG since it relied on some small EasyRPG plugin before, but I've seen a few people wishing they could do something similar, so I thought it might be a good idea include them in the original Player distribution.

Fixed battler facing direction

Normally battlers turn around to face the unit they're currently attacking, which is undesirable if you're build an old school RPG like the aforementioned Lufia V. This feature adds an option to make sure the battlers only ever face a single direction no matter what. It only affects how sprites are displayed and is purely cosmetic, no changes to the actual battle processing.

Horizontal ally/enemy select

This one is a logical consequence to the previous feature - if you're lining up all units horizontally next to each other it feels weird to select them with up/down buttons. It adds an option to select allies/enemies by pressing left/right instead of up/down.

@Ghabry
Copy link
Member

Ghabry commented Jul 10, 2023

This raises the question if "no flip" is really what you want for all battle types because some of them will break completely like "Pincer" or "Sourround" or "Back attack".

Obviously this "don't flip" is designed for the "Normal" and the "Initiative" battle system only because with manual placement they can be modified to be kinda like "Front facing" battle.

grafik


EDIT: For Sourround and Pincer it is unusable but for everything else this will likely work.

@Primekick
Copy link
Contributor Author

Obviously this "don't flip" is designed for the "Normal" and the "Initiative" battle system only because with manual placement they can be modified to be kinda like "Front facing" battle.

Yes, that was exactly the intent behind this feature. Honestly I completely forgot that Surround and Pincer battles even exist since they're hardly ever used in games, but yeah better restrict that to Normal/Initiative just in case.

@Ghabry
Copy link
Member

Ghabry commented Jul 27, 2023

random idea: will it break to just always allow "left/right" for enemy selection combined with "up/down"? Will be incompatible with RPG_RT (but not in a breaking way) and avoids a chunk.

@Ghabry
Copy link
Member

Ghabry commented Jul 28, 2023

The facing looks fine. For the left/right navigation I figured out a better solution but I couldn't get it working and I'm on vacation by tomorrow. So this has to wait until I'm back. sorry.

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left/Right to move cursor up/down in battle 2k3 is now enabled by default. Removed the commits and simplified them.

The flip commits remain untouched.

@fdelapena fdelapena merged commit 42a5683 into EasyRPG:master Sep 21, 2023
4 checks passed
@Ghabry Ghabry added this to the 0.8.1 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants