Ineluki MP3 patch improvements #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only consider files as links when they are small (< 500 Byte). "Les aventures d'un avatar 6" uses files with such names for real audio files. Support of links for sound effects with the same logic as BGM. Note that the "loop" statement is not supported. Fix EasyRPG#2598 Fix EasyRPG#2609
fdelapena
approved these changes
Sep 19, 2023
| } | ||
|
|
||
| if (!se_cache) { | ||
| Output::Warning("Sound {}: Format not supported", result->file); |
There was a problem hiding this comment.
Maybe this brings warnings where RPG_RT.exe won't? Use Output::Debug instead?
There was a problem hiding this comment.
this is copy-pasted from the non-Ineluki SE handler.
The warning will only trigger when a SE file is unsupported format wise. Missing files won't trigger it so should be save imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only consider files as links when they are small (< 500 Byte). "Les aventures d'un avatar 6" uses files with such names for real audio files.
Support of links for sound effects with the same logic as BGM. Note that the "loop" statement is not supported.
Fix #2598
Fix #2609