Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dr_wav to v0.13.12 #3115

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Update dr_wav to v0.13.12 #3115

merged 1 commit into from
Oct 21, 2023

Conversation

carstene1ns
Copy link
Member

This brings us crash fixes and AIFF/RIFX support.

This brings us chrash fixes and AIFF support
@carstene1ns carstene1ns added this to the 0.8.1 milestone Oct 6, 2023
@Ghabry
Copy link
Member

Ghabry commented Oct 9, 2023

Thanks for the update. I checked the source to figure out the fourcc codes drwav supports right now, useful for a later audio decoder update:

    if (drwav_fourcc_equal(riff, "RIFF")) {
        pWav->container = drwav_container_riff;
    } else if (drwav_fourcc_equal(riff, "RIFX")) {
        pWav->container = drwav_container_rifx;
    } else if (drwav_fourcc_equal(riff, "riff")) {
        int i;
        drwav_uint8 riff2[12];

        pWav->container = drwav_container_w64;

        /* Check the rest of the GUID for validity. */
        if (drwav__on_read(pWav->onRead, pWav->pUserData, riff2, sizeof(riff2), &cursor) != sizeof(riff2)) {
            return DRWAV_FALSE;
        }

        for (i = 0; i < 12; ++i) {
            if (riff2[i] != drwavGUID_W64_RIFF[i+4]) {
                return DRWAV_FALSE;
            }
        }
    } else if (drwav_fourcc_equal(riff, "RF64")) {
        pWav->container = drwav_container_rf64;
    } else if (drwav_fourcc_equal(riff, "FORM")) {
        pWav->container = drwav_container_aiff;
    } else {
        return DRWAV_FALSE;   /* Unknown or unsupported container. */
    }

Complete list:

RIFF
RIFX
riff
RF64
FORM

These are more formats than we list for libsndfile right now but the list is just incomplete.

@Ghabry Ghabry merged commit c8576e0 into EasyRPG:master Oct 21, 2023
4 checks passed
@carstene1ns carstene1ns deleted the update/dr_wav branch October 22, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants