Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maniacs Feature - "Skip Dialogs" from Fatal Mix. #3147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jetrotal
Copy link
Contributor

Hold ESC to skip all dialogs when in Debug Mode.

Things to consider:

  • Need an alternative to strlen(text_index) < 3. Since the textboxes can stop while being bigger than 3 characters,
    if the com.string has more than 4 lines of text.
  • We need a flag that works as an alternative to Player::debug_flag, so people can use it in their games
    (both shift and this skip should be activated?)

@Br4ssman
Copy link

I had thought about this, e.g. even if you config a text speed (slow), it could exists another new code for dialogs, that allows player press a key to accelerate the dialogs. While enter is pressed, dialog speed up, if not, then its config speed. What do you think?

@Ghabry
Copy link
Member

Ghabry commented Nov 13, 2023

FYI: There is already "message appears without delay" when holding shift. So you can already hold shift and hammer decision for the same result.

@jetrotal
Copy link
Contributor Author

jetrotal commented Nov 13, 2023

yeah, what I did was similar to what was asked at #2490

I'm thinking about applying the following flags:
SkipMessage = 0; // debug only
SkipMessage = 1; // imitates the shift one
SkipMessage = 2; // faster skip + auto enter implementation.

@jetrotal
Copy link
Contributor Author

After a second look, they want something similar do Maniac's Fatal Mix as a flag:
image

Weird part, is that it's attached to Right Shift. That could be a problem

@jetrotal jetrotal changed the title New Feature - Skip Dialogs Maniacs Feature - "Skip Dialogs" from Fatal Mix. Nov 13, 2023
That will help me seeing how to implement the alternative skip dialogs.

Update game_interpreter.cpp
@fdelapena fdelapena added the Awaiting Rebase Pull requests with conflicting files due to former merge label Nov 20, 2023
@Ghabry Ghabry added this to the 0.8.1 milestone Mar 11, 2024
@Ghabry
Copy link
Member

Ghabry commented Mar 11, 2024

Do you want this auto-enter behaviour available in general or just when this fatal mix skip option is enabled?

@jetrotal
Copy link
Contributor Author

jetrotal commented Mar 11, 2024

Oh boy, lemme try to remember how I set this up...
Huh, I didn't remember I also mapped fatal mix stuff.

If I remember correctly, my code was very similar to the fatal mix behavior.
But I found it useful on vanilla games as well.
It was a faster skip withtout hammering enter. And could be used in game, not only Debug.

Right now, maybe we should stick it to the fatal mix?

Maybe in the future, would be interesting to have a way of accessing maniacs commands even with it disabled...?

@Ghabry
Copy link
Member

Ghabry commented Mar 11, 2024

Considering it is a debug feature it could be an option in the settings whether you want "Instant text" with Shift or "Instant auto enter text" with Shift. 🤔

@jetrotal
Copy link
Contributor Author

Considering it is a debug feature it could be an option in the settings whether you want "Instant text" with Shift or "Instant auto enter text" with Shift. 🤔

Sure, it could also come with a setting

@Ghabry Ghabry modified the milestones: 0.8.1, 0.8.2 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Rebase Pull requests with conflicting files due to former merge Enhancement
Development

Successfully merging this pull request may close these issues.

4 participants