Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Beloved Rapture Menu issues #3293

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Fix Beloved Rapture Menu issues #3293

merged 8 commits into from
Nov 18, 2024

Commits on Nov 8, 2024

  1. Common Events: Add GetId() function 

    Not used but does not hurt...
    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bf7f526 View commit details
    Browse the repository at this point in the history

  2. Conditional Branch: Add Maniac indirection for Items, Actors and Events

    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    adbf2f4 View commit details
    Browse the repository at this point in the history

  3. Maniac Expressions: Support InPlace-Operations 

    They are disabled when EasyRpg-Mode is active as I consider this bad practice. Can result in hard-to-find bugs.
    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8cea789 View commit details
    Browse the repository at this point in the history

  4. String Variables: Fix off-by-one error in Split when counting the ele… 

    …ments
    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f26d9c3 View commit details
    Browse the repository at this point in the history

  5. String Variables: Remove the UTF-8 byte order mask when reading in a … 

    …file with Unicode encoding

Maniac Patch appears to do something similiar
    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1e423d9 View commit details
    Browse the repository at this point in the history

  6. Assign a unique ID to string pictures 

    Fix EasyRPG#3287
    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d0e696a View commit details
    Browse the repository at this point in the history

  7. Correctly calculate the screen dimensions when the resolution is not … 

    …dividable by the tile size.

Rename the screen variables in the Parallax code as the same name (var shadowing) is confusing.

Fixes incorrect scrolling of the map in Beloved Rapture
    @Ghabry
    Ghabry committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e7767ff View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Fix crash when using a hue changed enemy 

    Thats another regression caused by the requirement of an ID for the SpriteEffect. Replaced the assert with a debug log as this already caused 3 issues.
    @Ghabry
    Ghabry committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8552a45 View commit details
    Browse the repository at this point in the history