Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow and cmakery #474

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update workflow and cmakery #474

merged 1 commit into from
Mar 26, 2024

Conversation

carstene1ns
Copy link
Member

  • Better use as submodule, without install target (useful for flatpak)
  • Prevent in-source builds

@carstene1ns carstene1ns added this to the 0.8.1 milestone Dec 31, 2023
@carstene1ns @Ghabry
Update workflow and cmakery
5482126 
Better use as submodule, without install target (useful for flatpak)
Prevent in-source builds
Ghabry
Ghabry approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for ignoring such an easy-to-review change for so long...

I fixed the runners (ca-certificates added) and the Windows PR builder (in source build).

@Ghabry Ghabry requested a review from fdelapena March 25, 2024 22:50
@Ghabry Ghabry merged commit 75ed941 into EasyRPG:master Mar 26, 2024
10 checks passed
@Ghabry
Copy link
Member

Ghabry commented Mar 26, 2024

The Player flatpak file requires an update because it does an in-source build of liblcf

@carstene1ns carstene1ns deleted the workflow branch March 26, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghabry Ghabry Ghabry approved these changes

@fdelapena fdelapena fdelapena approved these changes

Assignees
No one assigned
Labels
Building
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@carstene1ns @Ghabry @fdelapena