Add chunks/commands for Jetrotal #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used by "Wait for Single Movement" command
fdelapena
approved these changes
Apr 13, 2024
florianessl
reviewed
May 23, 2024
src/generated/lcf/lsd/chunks.h
Outdated
| @@ -737,7 +737,13 @@ namespace LSD_Reader { | |||
| /** */ | |||
| keyinput_timed = 0x29, | |||
| /** Used for a wait command WaitForKeyInput rm2k3 feature to wait for decision key press. */ | |||
| wait_key_enter = 0x2A | |||
| wait_key_enter = 0x2A, | |||
| /** */ | |||
There was a problem hiding this comment.
Comments from the .csv are missing here. Those were probably applied afterwards without re-generating the files?
Contrary to RPG_RT this does not require adding new fields everytime a new event is added that waits.
|
This old one from ellie, is close to completion too: maybe worthy taking off the draft tag from it, and changing its syntax (e.g.: ID 2001 is already used, if I'm not wrong. And the verbose syntaxes inside strings may need some consideration). |
|
Because this conflicted I shifted the commands from ellie to 2003 and 2004. Also added most other commands where I'm certain that they will be added sooner or later. |
fdelapena
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding constants for stuff where I'm sure that they will go in.